Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1771713002: Reorganize tool/input_sdk/private (Closed)

Created:
4 years, 9 months ago by Jennifer Messerly
Modified:
4 years, 9 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reorganize tool/input_sdk/private In particular, this moves DDC's magic runtime library into its own folder. The runtime library doesn't follow the same rules as other libraries, so it's easier to reason about in its own folder. This is only file moves + changing libraries.dart to point at the new location. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/210bc78d6b9f556dc13bd3882843b0dc7651aba0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-7 lines, -1923 lines) Patch
M tool/input_sdk/lib/_internal/libraries.dart View 1 chunk +1 line, -1 line 0 comments Download
D tool/input_sdk/private/classes.dart View 1 chunk +0 lines, -376 lines 0 comments Download
A + tool/input_sdk/private/ddc_runtime/classes.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk/private/ddc_runtime/errors.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk/private/ddc_runtime/generators.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk/private/ddc_runtime/operations.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk/private/ddc_runtime/rtti.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk/private/ddc_runtime/runtime.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk/private/ddc_runtime/types.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk/private/ddc_runtime/utils.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D tool/input_sdk/private/errors.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D tool/input_sdk/private/generators.dart View 1 chunk +0 lines, -223 lines 0 comments Download
D tool/input_sdk/private/operations.dart View 1 chunk +0 lines, -431 lines 0 comments Download
D tool/input_sdk/private/rtti.dart View 1 chunk +0 lines, -176 lines 0 comments Download
D tool/input_sdk/private/runtime.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D tool/input_sdk/private/types.dart View 1 chunk +0 lines, -546 lines 0 comments Download
D tool/input_sdk/private/utils.dart View 1 chunk +0 lines, -115 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jennifer Messerly
4 years, 9 months ago (2016-03-06 22:10:15 UTC) #3
vsm
lgtm!
4 years, 9 months ago (2016-03-08 23:17:47 UTC) #4
Jennifer Messerly
4 years, 9 months ago (2016-03-08 23:52:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
210bc78d6b9f556dc13bd3882843b0dc7651aba0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698