DescriptionRevert of Fix SVGDocument return title that is not a child of the root element (patchset #12 id:220001 of https://codereview.chromium.org/1752713002/ )
Reason for revert:
Crash in blink:Document::setTitleElement.
Issue : https://bugs.chromium.org/p/chromium/issues/detail?id=592323
Original issue's description:
> Fix SVGDocument return title that is not a child of the root element
>
> The title element should be a child of the root element.
> But currently return invalid title that is not a child of the root element.
>
> Because on getting, if the root element is an svg element in the SVG
> namespace, then let value ba a concatenation of the data of all
> the child Text nodes of the first title element in the SVG namespace
> that is a child of the root element.[1]
>
> And on setting, let element be the first title element in the SVG
> namespace that is a child of the root element, if any.
> If there isn't one, create a title element in the SVG namespace,
> insert it as the first child of the root element, and let element
> be that element.[1]
>
> [1] https://html.spec.whatwg.org/multipage/dom.html#document.title
>
> BUG=543061
>
> Committed: https://crrev.com/2764e5d8a0ec6cf13cb4d918a5032e45da691247
> Cr-Commit-Position: refs/heads/master@{#379301}
TBR=fs@opera.com,pdr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=54306, 592323
Committed: https://crrev.com/b25217584cf92b17941a2db757baa2efd93a77d8
Cr-Commit-Position: refs/heads/master@{#379541}
Patch Set 1 #
Messages
Total messages: 14 (6 generated)
|