Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1771703003: Revert of Fix SVGDocument return title that is not a child of the root element (Closed)

Created:
4 years, 9 months ago by hyunjunekim2
Modified:
4 years, 9 months ago
Reviewers:
pdr., nyerramilli, fs
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix SVGDocument return title that is not a child of the root element (patchset #12 id:220001 of https://codereview.chromium.org/1752713002/ ) Reason for revert: Crash in blink:Document::setTitleElement. Issue : https://bugs.chromium.org/p/chromium/issues/detail?id=592323 Original issue's description: > Fix SVGDocument return title that is not a child of the root element > > The title element should be a child of the root element. > But currently return invalid title that is not a child of the root element. > > Because on getting, if the root element is an svg element in the SVG > namespace, then let value ba a concatenation of the data of all > the child Text nodes of the first title element in the SVG namespace > that is a child of the root element.[1] > > And on setting, let element be the first title element in the SVG > namespace that is a child of the root element, if any. > If there isn't one, create a title element in the SVG namespace, > insert it as the first child of the root element, and let element > be that element.[1] > > [1] https://html.spec.whatwg.org/multipage/dom.html#document.title > > BUG=543061 > > Committed: https://crrev.com/2764e5d8a0ec6cf13cb4d918a5032e45da691247 > Cr-Commit-Position: refs/heads/master@{#379301} TBR=fs@opera.com,pdr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=54306, 592323 Committed: https://crrev.com/b25217584cf92b17941a2db757baa2efd93a77d8 Cr-Commit-Position: refs/heads/master@{#379541}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -82 lines) Patch
A third_party/WebKit/LayoutTests/imported/web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-09-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/svg-document-set-title-mutations.html View 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 2 chunks +8 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTitleElement.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTitleElement.cpp View 2 chunks +1 line, -19 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
hyunjunekim2
Created Revert of Fix SVGDocument return title that is not a child of the root ...
4 years, 9 months ago (2016-03-07 07:36:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771703003/1
4 years, 9 months ago (2016-03-07 07:37:03 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 9 months ago (2016-03-07 07:37:05 UTC) #4
hyunjunekim2
fs, nyerramilli Could you revert this one? This case has been crash. var doc = ...
4 years, 9 months ago (2016-03-07 10:41:51 UTC) #7
fs
lgtm
4 years, 9 months ago (2016-03-07 11:21:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771703003/1
4 years, 9 months ago (2016-03-07 11:21:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 12:38:50 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 12:41:11 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b25217584cf92b17941a2db757baa2efd93a77d8
Cr-Commit-Position: refs/heads/master@{#379541}

Powered by Google App Engine
This is Rietveld 408576698