Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1771583002: sk_sp: fix contravariant constructors (Closed)

Created:
4 years, 9 months ago by hal.canary
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

sk_sp: fix contravariant constructors TBR=reed This is obviously correct and needs to be fixed. Committed: https://skia.googlesource.com/skia/+/ffa39e02bc34a33c23fcccd61b781b5d05a980d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M include/core/SkRefCnt.h View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/RefCntTest.cpp View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
hal.canary
ptal
4 years, 9 months ago (2016-03-05 13:35:02 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771583002/1
4 years, 9 months ago (2016-03-05 13:38:06 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-05 13:48:23 UTC) #9
bungeman-skia
heh, I realized this last night and wrote https://codereview.chromium.org/1762273004/ . lgtm
4 years, 9 months ago (2016-03-05 16:25:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771583002/1
4 years, 9 months ago (2016-03-05 16:29:37 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-05 16:30:32 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ffa39e02bc34a33c23fcccd61b781b5d05a980d3

Powered by Google App Engine
This is Rietveld 408576698