Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1771553002: Revert of [wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript. (Closed)

Created:
4 years, 9 months ago by adamk
Modified:
4 years, 9 months ago
Reviewers:
titzer, seththompson, binji
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript. (patchset #2 id:20001 of https://codereview.chromium.org/1762203002/ ) Reason for revert: New test test-wasm-module-builder fails on Linux - shared bot: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/builds/8793 Original issue's description: > [wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript. > > R=binji@chromium.org,seththompson@chromium.org > BUG= > > Committed: https://crrev.com/d130c6bdc6a424b068614592a0b79a34750af0fc > Cr-Commit-Position: refs/heads/master@{#34513} TBR=binji@chromium.org,seththompson@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/6479b01affdcf2250b5d05f446f583cb9f8e2f33 Cr-Commit-Position: refs/heads/master@{#34514}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -401 lines) Patch
D test/mjsunit/wasm/test-wasm-module-builder.js View 1 chunk +0 lines, -90 lines 0 comments Download
D test/mjsunit/wasm/wasm-module-builder.js View 1 chunk +0 lines, -311 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
adamk
Created Revert of [wasm] Add a JavaScript utility to make it easier to build WASM ...
4 years, 9 months ago (2016-03-05 02:20:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771553002/1
4 years, 9 months ago (2016-03-05 02:20:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-05 02:20:56 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-05 02:21:30 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6479b01affdcf2250b5d05f446f583cb9f8e2f33
Cr-Commit-Position: refs/heads/master@{#34514}

Powered by Google App Engine
This is Rietveld 408576698