Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 1771503002: Ensure that calls to EnableGrowthControl/DisableGrowthControl does not reset the last_usage_ value … (Closed)

Created:
4 years, 9 months ago by siva
Modified:
4 years, 9 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ensure that calls to EnableGrowthControl/DisableGrowthControl does not reset the last_usage_ value as this can result in the heuristic constantly growing the heap instead of GCing. This was observed with the background compilation being turned on as we disable growth control during installation of code in the background compiler thread. R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/0bd9c547924c212c19498f84025c0fd8a2df661d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M runtime/vm/dart.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/heap.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/pages.h View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
4 years, 9 months ago (2016-03-04 23:58:21 UTC) #2
Ivan Posva
LGTM -ip
4 years, 9 months ago (2016-03-05 00:05:31 UTC) #3
siva
4 years, 9 months ago (2016-03-05 00:17:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0bd9c547924c212c19498f84025c0fd8a2df661d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698