Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: runtime/vm/raw_object_snapshot.cc

Issue 1771483002: Include the canonical static closure when serializing ClosureData. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tests/isolate/isolate.status » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/native_entry.h" 5 #include "vm/native_entry.h"
6 #include "vm/object.h" 6 #include "vm/object.h"
7 #include "vm/object_store.h" 7 #include "vm/object_store.h"
8 #include "vm/snapshot.h" 8 #include "vm/snapshot.h"
9 #include "vm/stub_code.h" 9 #include "vm/stub_code.h"
10 #include "vm/symbols.h" 10 #include "vm/symbols.h"
(...skipping 714 matching lines...) Expand 10 before | Expand all | Expand 10 after
725 writer->WriteVMIsolateObject(kNullObject); 725 writer->WriteVMIsolateObject(kNullObject);
726 } 726 }
727 } 727 }
728 728
729 // Parent function. 729 // Parent function.
730 writer->WriteObjectImpl(ptr()->parent_function_, kAsInlinedObject); 730 writer->WriteObjectImpl(ptr()->parent_function_, kAsInlinedObject);
731 731
732 // Signature type. 732 // Signature type.
733 writer->WriteObjectImpl(ptr()->signature_type_, kAsInlinedObject); 733 writer->WriteObjectImpl(ptr()->signature_type_, kAsInlinedObject);
734 734
735 // Static closure/Closure allocation stub. 735 // Canonical static closure.
736 // We don't write the closure or allocation stub in the snapshot. 736 writer->WriteObjectImpl(ptr()->closure_, kAsInlinedObject);
737 writer->WriteVMIsolateObject(kNullObject);
738 } 737 }
739 738
740 739
741 RawRedirectionData* RedirectionData::ReadFrom(SnapshotReader* reader, 740 RawRedirectionData* RedirectionData::ReadFrom(SnapshotReader* reader,
742 intptr_t object_id, 741 intptr_t object_id,
743 intptr_t tags, 742 intptr_t tags,
744 Snapshot::Kind kind, 743 Snapshot::Kind kind,
745 bool as_reference) { 744 bool as_reference) {
746 ASSERT(reader != NULL); 745 ASSERT(reader != NULL);
747 ASSERT((kind == Snapshot::kScript) || (kind == Snapshot::kFull)); 746 ASSERT((kind == Snapshot::kScript) || (kind == Snapshot::kFull));
(...skipping 2983 matching lines...) Expand 10 before | Expand all | Expand 10 after
3731 // We do not allow objects with native fields in an isolate message. 3730 // We do not allow objects with native fields in an isolate message.
3732 writer->SetWriteException(Exceptions::kArgument, 3731 writer->SetWriteException(Exceptions::kArgument,
3733 "Illegal argument in isolate message" 3732 "Illegal argument in isolate message"
3734 " : (object is a UserTag)"); 3733 " : (object is a UserTag)");
3735 } else { 3734 } else {
3736 UNREACHABLE(); 3735 UNREACHABLE();
3737 } 3736 }
3738 } 3737 }
3739 3738
3740 } // namespace dart 3739 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | tests/isolate/isolate.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698