Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1771473002: [MemoryCache] Exclude data URLs and SubstituteData from MemoryCache UMAs (Closed)

Created:
4 years, 9 months ago by hiroshige
Modified:
4 years, 9 months ago
Reviewers:
Nate Chapin, yhirano
CC:
chromium-reviews, tyoshino+watch_chromium.org, Yoav Weiss, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MemoryCache] Exclude data URLs and SubstituteData from MemoryCache UMAs BUG=591079 Committed: https://crrev.com/6504eda85055ce372f0a77bd387e0567d8f3ea7f Cr-Commit-Position: refs/heads/master@{#379435}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reflect comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -12 lines) Patch
M third_party/WebKit/Source/core/fetch/ResourceFetcher.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 1 2 chunks +21 lines, -12 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771473002/1
4 years, 9 months ago (2016-03-04 23:32:07 UTC) #2
hiroshige
PTAL. SubstituteData should be excluded from MemoryCache UMA, because it will no longer added to ...
4 years, 9 months ago (2016-03-04 23:33:11 UTC) #4
Nate Chapin
lgtm https://codereview.chromium.org/1771473002/diff/1/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp File third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp (right): https://codereview.chromium.org/1771473002/diff/1/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp#newcode437 third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp:437: if (!isStaticData) { Maybe put the contents of ...
4 years, 9 months ago (2016-03-04 23:44:00 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771473002/20001
4 years, 9 months ago (2016-03-05 00:02:22 UTC) #7
hiroshige
https://codereview.chromium.org/1771473002/diff/1/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp File third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp (right): https://codereview.chromium.org/1771473002/diff/1/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp#newcode437 third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp:437: if (!isStaticData) { On 2016/03/04 23:44:00, Nate Chapin wrote: ...
4 years, 9 months ago (2016-03-05 00:03:55 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-05 01:18:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771473002/20001
4 years, 9 months ago (2016-03-05 02:11:33 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-05 02:17:29 UTC) #16
commit-bot: I haz the power
4 years, 9 months ago (2016-03-05 02:18:43 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6504eda85055ce372f0a77bd387e0567d8f3ea7f
Cr-Commit-Position: refs/heads/master@{#379435}

Powered by Google App Engine
This is Rietveld 408576698