[MemoryCache] Exclude data URLs and SubstituteData from MemoryCache UMAs

[MemoryCache] Exclude data URLs and SubstituteData from MemoryCache UMAs

BUG=591079
Committed: https://crrev.com/6504eda85055ce372f0a77bd387e0567d8f3ea7f
Cr-Commit-Position: refs/heads/master@{#379435}

[hiroshige, 2016-03-04 23:31:26]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-04 23:32:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1771473002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1771473002/1

[hiroshige, 2016-03-04 23:33:10]

hiroshige@chromium.org changed reviewers:
+ japhet@chromium.org, yhirano@chromium.org

[hiroshige, 2016-03-04 23:33:11]

PTAL.

SubstituteData should be excluded from MemoryCache UMA, because it will no
longer added to MemoryCache after https://codereview.chromium.org/1748723002/
(but without this patch it will still be included in the UMA).

Not so sure about data: URLs. I excluded data URLs also in this CL, what do you
think?

[Nate Chapin, 2016-03-04 23:44:00]

lgtm

https://codereview.chromium.org/1771473002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp (right):

https://codereview.chromium.org/1771473002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp:437: if (!isStaticData)
{
Maybe put the contents of this if() statement in a helper? It's getting to be
big enough that it deserves its own function.

[hiroshige, 2016-03-05 00:01:46]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-05 00:02:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1771473002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1771473002/20001

[hiroshige, 2016-03-05 00:03:55]

https://codereview.chromium.org/1771473002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp (right):

https://codereview.chromium.org/1771473002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp:437: if (!isStaticData)
{
On 2016/03/04 23:44:00, Nate Chapin wrote:
> Maybe put the contents of this if() statement in a helper? It's getting to be
> big enough that it deserves its own function.

Done. Also removed the if() statement because it is also related to UMA.

[hiroshige, 2016-03-05 00:03:58]

Description was changed from

==========
[MemoryCache] Exclude data URLs and SubstituteData from MemoryCache UMAs

BUG=
==========

to

==========
[MemoryCache] Exclude data URLs and SubstituteData from MemoryCache UMAs

BUG=591079
==========

[commit-bot: I haz the power, 2016-03-05 01:18:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-05 01:18:32]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-03-05 02:11:03]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2016-03-05 02:11:04]

The patchset sent to the CQ was uploaded after l-g-t-m from japhet@chromium.org
Link to the patchset: https://codereview.chromium.org/1771473002/#ps20001
(title: "Reflect comment")

[commit-bot: I haz the power, 2016-03-05 02:11:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1771473002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1771473002/20001

[commit-bot: I haz the power, 2016-03-05 02:17:28]

Description was changed from

==========
[MemoryCache] Exclude data URLs and SubstituteData from MemoryCache UMAs

BUG=591079
==========

to

==========
[MemoryCache] Exclude data URLs and SubstituteData from MemoryCache UMAs

BUG=591079
==========

[commit-bot: I haz the power, 2016-03-05 02:17:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-05 02:18:42]

Description was changed from

==========
[MemoryCache] Exclude data URLs and SubstituteData from MemoryCache UMAs

BUG=591079
==========

to

==========
[MemoryCache] Exclude data URLs and SubstituteData from MemoryCache UMAs

BUG=591079

Committed: https://crrev.com/6504eda85055ce372f0a77bd387e0567d8f3ea7f
Cr-Commit-Position: refs/heads/master@{#379435}
==========

[commit-bot: I haz the power, 2016-03-05 02:18:43]

Patchset 2 (id:??) landed as
https://crrev.com/6504eda85055ce372f0a77bd387e0567d8f3ea7f
Cr-Commit-Position: refs/heads/master@{#379435}