Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1771463002: Revert of Add lock to fix race in AudioRendererMixerInput. (Closed)

Created:
4 years, 9 months ago by chcunningham
Modified:
4 years, 9 months ago
Reviewers:
DaleCurtis, o1ka
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add lock to fix race in AudioRendererMixerInput. (patchset #5 id:80001 of https://codereview.chromium.org/1748183006/ ) Reason for revert: This seems to cause failures in LayoutTests/http/tests/security/media. Not sure why this wasn't caught by CQ... Tracking CQ weirdness here: https://bugs.chromium.org/p/chromium/issues/detail?id=592079 Original issue's description: > Add lock to fix race in AudioRendererMixerInput. > > Clusterfuzz identified a race between the media thread calling SetVolume > and the audio device thread calling ProvideInput. Add a lock to > synchronize access to |volume_| between threads. > > Also adds some thread_checkers to just firm up the contract that the > majority of these methods are called only by the media thread. > > BUG=588992 > > Committed: https://crrev.com/57c6958a99f2c62a4408d2a9d262a22129309106 > Cr-Commit-Position: refs/heads/master@{#379349} TBR=dalecurtis@chromium.org,olka@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=588992 Committed: https://crrev.com/6b206d7b4963be6e8e7ff269dcf0015eb7d8bffa Cr-Commit-Position: refs/heads/master@{#379388}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -43 lines) Patch
M media/base/audio_renderer_mixer_input.h View 2 chunks +0 lines, -10 lines 0 comments Download
M media/base/audio_renderer_mixer_input.cc View 10 chunks +2 lines, -33 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chcunningham
Created Revert of Add lock to fix race in AudioRendererMixerInput.
4 years, 9 months ago (2016-03-04 23:21:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771463002/1
4 years, 9 months ago (2016-03-04 23:21:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 23:22:09 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6b206d7b4963be6e8e7ff269dcf0015eb7d8bffa Cr-Commit-Position: refs/heads/master@{#379388}
4 years, 9 months ago (2016-03-04 23:24:04 UTC) #6
o1ka
4 years, 9 months ago (2016-03-07 16:22:40 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698