Issue 1771423002: Qualify the precompiled shared library name with the snapshot directory instead of using LD_LIBRARY…

Issue 1771423002: Qualify the precompiled shared library name with the snapshot directory instead of using LD_LIBRARY… (Closed)

Created:
4 years, 9 months ago by rmacnak

Modified:
4 years, 9 months ago

Reviewers:
Cutch, kasperl

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Qualify the precompiled shared library name with the snapshot directory instead of using LD_LIBRARY_PATH. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/a0e3bfdd687c06dda92f02f38c017e303977c962

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -12 lines)			Patch
M	runtime/bin/main.cc	View		3 chunks	+22 lines, -5 lines	0 comments	Download
M	tools/precompilation/test_linux.sh	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/precompilation/test_linux_simarm.sh	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/precompilation/test_macos.sh	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/testing/dart/runtime_configuration.dart	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download

Total messages: 8 (3 generated)

rmacnak

Committed patchset #3 (id:40001) manually as a0e3bfdd687c06dda92f02f38c017e303977c962 (presubmit successful).

4 years, 9 months ago (2016-03-08 20:01:58 UTC) #6

kasperl

4 years, 9 months ago (2016-03-08 20:08:10 UTC) #8

Message was sent while issue was closed.

So from now on, you'll find libprecompiled.so next to the two snapshots? Sound
pretty good to me!