Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1771393006: Remove WebPrerenderingSupport::shutdown from blink::shutdown (Closed)

Created:
4 years, 9 months ago by haraken
Modified:
4 years, 9 months ago
Reviewers:
sof, gavinp
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebPrerenderingSupport::shutdown from blink::shutdown WebPrerenderingSupport::initialize/shutdown is called in PrerenderDispatcher's constructor/destructor. There would be no need to call WebPrerenderingSupport::shutdown from blink::shutdown. (It looks strange to call WebPrerenderingSupport::shutdown in blink::shutdown whereas WebPrerenderingSupport::initialize is not called in blink::initialize.) The code was added in https://chromium.googlesource.com/chromium/src/+/b5d48114fbb738a58cb58b9023c1e25ea94a9ec0 four years ago. BUG=593269 Committed: https://crrev.com/3a93d12a5e0b250e9c0e9b3b5d47208454c5e350 Cr-Commit-Position: refs/heads/master@{#380845}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/platform/exported/Platform.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
haraken
PTAL
4 years, 9 months ago (2016-03-09 12:17:29 UTC) #2
sof
This is for gavinp@ , but making the shutdown of PrerenderDispatcher and Blink happen in ...
4 years, 9 months ago (2016-03-09 12:34:08 UTC) #3
sof
On 2016/03/09 12:34:08, sof wrote: > This is for gavinp@ , but making the shutdown ...
4 years, 9 months ago (2016-03-09 12:35:38 UTC) #4
haraken
gavinp@: Would you take a look at this?
4 years, 9 months ago (2016-03-10 11:09:36 UTC) #5
gavinp
On 2016/03/10 11:09:36, haraken wrote: > gavinp@: Would you take a look at this? lgtm. ...
4 years, 9 months ago (2016-03-11 19:08:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771393006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771393006/20001
4 years, 9 months ago (2016-03-12 02:14:03 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/188359)
4 years, 9 months ago (2016-03-12 02:36:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771393006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771393006/20001
4 years, 9 months ago (2016-03-12 02:58:20 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-12 04:43:46 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-12 04:45:55 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3a93d12a5e0b250e9c0e9b3b5d47208454c5e350
Cr-Commit-Position: refs/heads/master@{#380845}

Powered by Google App Engine
This is Rietveld 408576698