Convert mus apptests to shelltests

Convert mus apptests to shelltests

This reworks some shelltest boilerplate to be more easily
consumable and converts all mus apptests to shelltests.

BUG=592313
Committed: https://crrev.com/6a2b04272ba5fd3dad9c62f03144bad04e6cfa65
Cr-Commit-Position: refs/heads/master@{#380148}

[Ken Rockot(use gerrit already), 2016-03-08 17:56:32]

rockot@chromium.org changed reviewers:
+ ben@chromium.org

[Ken Rockot(use gerrit already), 2016-03-08 17:56:33]

so much faster

[Ben Goodger (Google), 2016-03-08 18:07:23]

https://codereview.chromium.org/1771393002/diff/1/components/mus/ws/BUILD.gn
File components/mus/ws/BUILD.gn (right):

https://codereview.chromium.org/1771393002/diff/1/components/mus/ws/BUILD.gn#...
components/mus/ws/BUILD.gn:196: test("window_manager_shelltests") {
rather than calling these out as a separate test suite, I think you can just
merge these files into window_manager_unittests.

window_manager_unittests should probably be called mus_ws_unittests

[Ken Rockot(use gerrit already), 2016-03-08 18:10:12]

I chose not to do this because starting a background shell still carries a
lot of build and runtime cost with it. Not as heavy as apptests, but still
quite a bit more than nothing at all.

On Tue, Mar 8, 2016 at 10:07 AM, <ben@chromium.org> wrote:

>
>
> https://codereview.chromium.org/1771393002/diff/1/components/mus/ws/BUILD.gn
> File components/mus/ws/BUILD.gn (right):
>
>
>
https://codereview.chromium.org/1771393002/diff/1/components/mus/ws/BUILD.gn#...
> components/mus/ws/BUILD.gn:196: test("window_manager_shelltests") {
> rather than calling these out as a separate test suite, I think you can
> just merge these files into window_manager_unittests.
>
> window_manager_unittests should probably be called mus_ws_unittests
>
> https://codereview.chromium.org/1771393002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ben Goodger (Google), 2016-03-08 18:13:01]

ben@chromium.org changed reviewers:
+ sky@chromium.org

[Ben Goodger (Google), 2016-03-08 18:13:01]

Sky had expressed preference for merging. +cc

[sky, 2016-03-08 22:40:35]

On 2016/03/08 18:13:01, Ben Goodger (Google) wrote:
> Sky had expressed preference for merging. +cc

The build costs shouldn't amount to much more than is already built. In fact I
suspect combining into a single target is less build cost overall.
I do agree that background shell tests are slower, but I don't envision a ton
more being added and would prefer the single target.

[Ken Rockot(use gerrit already), 2016-03-08 23:19:12]

On 2016/03/08 at 22:40:35, sky wrote:
> On 2016/03/08 18:13:01, Ben Goodger (Google) wrote:
> > Sky had expressed preference for merging. +cc
> 
> The build costs shouldn't amount to much more than is already built. In fact I
suspect combining into a single target is less build cost overall.
> I do agree that background shell tests are slower, but I don't envision a ton
more being added and would prefer the single target.

OK SGTM, I'll fold them back into unittests

[Ken Rockot(use gerrit already), 2016-03-09 00:24:30]

Everything's in mus_ws_unittests now, PTAL!

[Ben Goodger (Google), 2016-03-09 00:41:51]

lgtm

[sky, 2016-03-09 00:50:42]

LGTM

https://codereview.chromium.org/1771393002/diff/20001/components/mus/public/c...
File components/mus/public/cpp/tests/window_manager_shelltest_base.h (right):

https://codereview.chromium.org/1771393002/diff/20001/components/mus/public/c...
components/mus/public/cpp/tests/window_manager_shelltest_base.h:15: class
WindowManagerShellTestBase : public mojo::test::ShellTest {
WindowManager->WindowServer

[Ken Rockot(use gerrit already), 2016-03-09 01:06:23]

On 2016/03/09 at 00:50:42, sky wrote:
> LGTM
> 
>
https://codereview.chromium.org/1771393002/diff/20001/components/mus/public/c...
> File components/mus/public/cpp/tests/window_manager_shelltest_base.h (right):
> 
>
https://codereview.chromium.org/1771393002/diff/20001/components/mus/public/c...
> components/mus/public/cpp/tests/window_manager_shelltest_base.h:15: class
WindowManagerShellTestBase : public mojo::test::ShellTest {
> WindowManager->WindowServer

done

[Ken Rockot(use gerrit already), 2016-03-09 01:06:25]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-03-09 01:06:26]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1771393002/#ps40001
(title: "fix component build")

[commit-bot: I haz the power, 2016-03-09 01:07:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1771393002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1771393002/40001

[commit-bot: I haz the power, 2016-03-09 01:21:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-09 01:21:30]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2016-03-09 06:33:17]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-03-09 06:33:18]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1771393002/#ps100001
(title: "fix buildbot configs")

[commit-bot: I haz the power, 2016-03-09 06:33:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1771393002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1771393002/100001

[commit-bot: I haz the power, 2016-03-09 07:10:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-09 07:10:52]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2016-03-09 15:51:28]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-03-09 15:51:29]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1771393002/#ps140001
(title: " ")

[commit-bot: I haz the power, 2016-03-09 15:51:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1771393002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1771393002/140001

[commit-bot: I haz the power, 2016-03-09 17:15:12]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-03-09 17:16:33]

Description was changed from

==========
Convert mus apptests to shelltests

This reworks some shelltest boilerplate to be more easily
consumable and converts all mus apptests to shelltests.

BUG=592313
==========

to

==========
Convert mus apptests to shelltests

This reworks some shelltest boilerplate to be more easily
consumable and converts all mus apptests to shelltests.

BUG=592313

Committed: https://crrev.com/6a2b04272ba5fd3dad9c62f03144bad04e6cfa65
Cr-Commit-Position: refs/heads/master@{#380148}
==========

[commit-bot: I haz the power, 2016-03-09 17:16:35]

Patchset 8 (id:??) landed as
https://crrev.com/6a2b04272ba5fd3dad9c62f03144bad04e6cfa65
Cr-Commit-Position: refs/heads/master@{#380148}