Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1771373002: Small GrTessellator refactor and cleanup. (Closed)

Created:
4 years, 9 months ago by Stephen White
Modified:
4 years, 9 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Small GrTessellator refactor and cleanup. Implement a VertexList, and use it. Rename insert<> -> list_insert<>. Rename remove<> -> list_remove<>. Remove some spurious returns. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1771373002 Committed: https://skia.googlesource.com/skia/+/e6eaa320e8dac34396dc364aa0863574d7b5291c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -42 lines) Patch
M src/gpu/GrTessellator.cpp View 13 chunks +37 lines, -42 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Stephen White
robertphillips@: PTAL. Thanks!
4 years, 9 months ago (2016-03-08 16:24:19 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771373002/1
4 years, 9 months ago (2016-03-08 16:25:10 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-08 16:38:27 UTC) #8
robertphillips
lgtm
4 years, 9 months ago (2016-03-08 17:01:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771373002/1
4 years, 9 months ago (2016-03-08 17:02:44 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 17:06:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e6eaa320e8dac34396dc364aa0863574d7b5291c

Powered by Google App Engine
This is Rietveld 408576698