Finish completeSweep before shutting down V8

third_party/WebKit/Source/platform/heap/HeapTest.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 5733 matching lines @@
     }
 
     static volatile IntWrapper* s_workerObjectPointer;
 };
 
 TEST(HeapTest, RecursiveMutex)
 {
     RecursiveLockingTester::test();
 }
 
-class CrossThreadPersistentOnMainThreadTester {

[haraken, 2016/03/10 10:45:18]

Would it make sense to remove this test?

-public:
-    static void test()
-    {
-        MutexLocker locker(mainThreadMutex());
-        OwnPtr<WebThread> workerThread = adoptPtr(Platform::current()->createThread("Test Worker Thread"));
-        workerThread->getWebTaskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(workerThreadMain));
-
-        parkMainThread();
-
-        // (Temporarily) detach main thread and wake the worker thread, so that it
-        // can do its detach().
-        ThreadState::detachMainThread();

[haraken, 2016/03/10 10:45:18]

It's not allowed to detach the main thread before detaching other threads.

-        wakeWorkerThread();
-
-        parkMainThread();
-        ThreadState::attachMainThread();
-    }
-
-private:
-
-    static void workerThreadMain()
-    {
-        MutexLocker locker(workerThreadMutex());
-
-        // Start up a worker thread and have it detach after the main thread has.
-        // Do this to verify that CrossThreadPersistent<>s referring to objects

[haraken, 2016/03/10 10:45:18]

The CrossThreadPersistent is not pointing to an object on the main thread (it's
pointing to the object on the worker thread)...

-        // on one of the main thread's arenas does not upset the CTP invalidation
-        // pass that ThreadState::detach() performs.
-        ThreadState::attach();
-
-        CrossThreadPersistent<IntWrapper> persistent(IntWrapper::create(43));
-
-        // Wait for the main thread to detach.
-        wakeMainThread();
-        parkWorkerThread();
-
-        ThreadState::detach();
-        wakeMainThread();
-    }
-};
-
-TEST(HeapTest, CrossThreadPersistentOnMainThread)
-{
-    CrossThreadPersistent<IntWrapper> persistent(IntWrapper::create(42));
-    CrossThreadPersistentOnMainThreadTester::test();
-}
-
 template<typename T>
 class TraceIfNeededTester : public GarbageCollectedFinalized<TraceIfNeededTester<T>> {
 public:
     static TraceIfNeededTester<T>* create() { return new TraceIfNeededTester<T>(); }
     static TraceIfNeededTester<T>* create(const T& obj) { return new TraceIfNeededTester<T>(obj); }
     DEFINE_INLINE_TRACE() { TraceIfNeeded<T>::trace(visitor, m_obj); }
     T& obj() { return m_obj; }
     ~TraceIfNeededTester() { }
 private:
     TraceIfNeededTester() { }
@@ skipping 719 matching lines @@
     EXPECT_EQ(1u, vector2.size());
 // TODO(Oilpan): when Vector.h's contiguous container support no longer disables
 // Vector<>s with inline capacity, remove.
 #if !defined(ANNOTATE_CONTIGUOUS_CONTAINER)
     EXPECT_EQ(16u, vector1.capacity());
     EXPECT_EQ(16u, vector2.capacity());
 #endif
 }
 
 } // namespace blink