Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Side by Side Diff: chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc

Issue 1771323002: Added H264 to chrome_webrtc_video_quality_browsertest.cc. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include "base/base64.h" 7 #include "base/base64.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/environment.h" 9 #include "base/environment.h"
10 #include "base/files/file.h" 10 #include "base/files/file.h"
(...skipping 12 matching lines...) Expand all
23 #include "chrome/browser/media/webrtc_browsertest_base.h" 23 #include "chrome/browser/media/webrtc_browsertest_base.h"
24 #include "chrome/browser/media/webrtc_browsertest_common.h" 24 #include "chrome/browser/media/webrtc_browsertest_common.h"
25 #include "chrome/browser/profiles/profile.h" 25 #include "chrome/browser/profiles/profile.h"
26 #include "chrome/browser/ui/browser.h" 26 #include "chrome/browser/ui/browser.h"
27 #include "chrome/browser/ui/browser_tabstrip.h" 27 #include "chrome/browser/ui/browser_tabstrip.h"
28 #include "chrome/browser/ui/tabs/tab_strip_model.h" 28 #include "chrome/browser/ui/tabs/tab_strip_model.h"
29 #include "chrome/common/chrome_switches.h" 29 #include "chrome/common/chrome_switches.h"
30 #include "chrome/test/base/in_process_browser_test.h" 30 #include "chrome/test/base/in_process_browser_test.h"
31 #include "components/infobars/core/infobar.h" 31 #include "components/infobars/core/infobar.h"
32 #include "content/public/browser/notification_service.h" 32 #include "content/public/browser/notification_service.h"
33 #include "content/public/common/feature_h264_with_openh264_ffmpeg.h"
34 #include "content/public/common/features.h"
33 #include "content/public/test/browser_test_utils.h" 35 #include "content/public/test/browser_test_utils.h"
34 #include "media/base/media_switches.h" 36 #include "media/base/media_switches.h"
35 #include "net/test/embedded_test_server/embedded_test_server.h" 37 #include "net/test/embedded_test_server/embedded_test_server.h"
36 #include "net/test/python_utils.h" 38 #include "net/test/python_utils.h"
37 #include "testing/perf/perf_test.h" 39 #include "testing/perf/perf_test.h"
38 #include "ui/gl/gl_switches.h" 40 #include "ui/gl/gl_switches.h"
39 41
40 namespace { 42 namespace {
41 std::string MakeLabel(const char* test_name, const std::string& video_codec) { 43 std::string MakeLabel(const char* test_name, const std::string& video_codec) {
42 std::string codec_label = video_codec.empty() ? "" : "_" + video_codec; 44 std::string codec_label = video_codec.empty() ? "" : "_" + video_codec;
(...skipping 324 matching lines...) Expand 10 before | Expand all | Expand 10 after
367 369
368 IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest, 370 IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest,
369 MANUAL_TestVideoQualityVp8) { 371 MANUAL_TestVideoQualityVp8) {
370 TestVideoQuality("VP8"); 372 TestVideoQuality("VP8");
371 } 373 }
372 374
373 IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest, 375 IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest,
374 MANUAL_TestVideoQualityVp9) { 376 MANUAL_TestVideoQualityVp9) {
375 TestVideoQuality("VP9"); 377 TestVideoQuality("VP9");
376 } 378 }
379
380 #if BUILDFLAG(RTC_USE_H264)
381
382 IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest,
383 MANUAL_TestVideoQualityH264) {
384 // Only run test if run-time feature corresponding to |rtc_use_h264| is on.
385 if (!base::FeatureList::IsEnabled(content::kWebRtcH264WithOpenH264FFmpeg)) {
386 LOG(WARNING) << "Run-time feature WebRTC-H264WithOpenH264FFmpeg disabled. "
387 "Skipping WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264 "
388 "(test \"OK\")";
389 return;
390 }
391 TestVideoQuality("H264");
392 }
393
394 #endif // BUILDFLAG(RTC_USE_H264)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698