Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1771313003: Reland of Fix param_name for Properties. (Closed)

Created:
4 years, 9 months ago by martiniss
Modified:
4 years, 9 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/recipes-py@master
Target Ref:
refs/heads/master
Project:
recipes-py
Visibility:
Public.

Description

Reland of Fix param_name for Properties. (patchset #1 id:1 of https://codereview.chromium.org/1756933003/ ) Reason for revert: Reland patch; still need to test. Original issue's description: > Revert of Fix param_name for Properties. (patchset #1 id:1 of https://codereview.chromium.org/1755593003/ ) > > Reason for revert: > Broke findit recipe which uses param_name. > > Original issue's description: > > Fix param_name for Properties. > > > > This allows for you to have a property 'event.patchset', which gets put into > > a python parameter name "event_patchset", for example. This behavior was > > previously broken. Added a working test for it. > > > > BUG=591172 > > > > Committed: https://github.com/luci/recipes-py/commit/b044190384a6b5330fbbda7d922f4ead3cc88fb8 > > TBR=iannucci@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=591172 > > Committed: https://github.com/luci/recipes-py/commit/3954063a6f438cff11211e8e9878e5587565a4f1 TBR=iannucci@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=591172 Committed: https://github.com/luci/recipes-py/commit/29717c344a792bd95108de6f76e051c8cb2bc776

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -17 lines) Patch
M recipe_engine/loader.py View 3 chunks +25 lines, -11 lines 0 comments Download
M recipe_engine/unittests/loader_test.py View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
martiniss
Created Reland of Fix param_name for Properties.
4 years, 9 months ago (2016-03-08 23:34:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771313003/1
4 years, 9 months ago (2016-03-10 00:08:34 UTC) #3
iannucci
lgtm
4 years, 9 months ago (2016-03-10 00:10:24 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 00:10:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/29717c344a792bd95108de6f76e051c8cb2...

Powered by Google App Engine
This is Rietveld 408576698