Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1771233002: Rename treeRoot to rootNode (Closed)

Created:
4 years, 9 months ago by yuzuchan
Modified:
4 years, 9 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename treeRoot to rootNode As a result of the discussion below, it has been decided that Node.treeRoot should be renamed to Node.rootNode. https://github.com/w3c/webcomponents/issues/80 See the DOM standard link here : https://dom.spec.whatwg.org/#dom-node-rootnode BUG=531990 Committed: https://crrev.com/146646ecfc48db4b591324e5888c7ffa9c68967f Cr-Commit-Position: refs/heads/master@{#380042}

Patch Set 1 #

Patch Set 2 : Modify histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -29 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/shadow/treeRoot.html View 2 chunks +23 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt View 4 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (11 generated)
hayato
lgtm
4 years, 9 months ago (2016-03-08 04:01:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771233002/1
4 years, 9 months ago (2016-03-08 04:02:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/154243)
4 years, 9 months ago (2016-03-08 04:12:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771233002/20001
4 years, 9 months ago (2016-03-08 06:38:47 UTC) #11
yuzuchan
Hello asvitkine@, can you please take a look at this CL and lgtm it if ...
4 years, 9 months ago (2016-03-08 06:47:14 UTC) #14
Alexei Svitkine (slow)
lgtm
4 years, 9 months ago (2016-03-08 15:16:09 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771233002/20001
4 years, 9 months ago (2016-03-09 02:40:13 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-09 02:46:54 UTC) #18
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 02:47:45 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/146646ecfc48db4b591324e5888c7ffa9c68967f
Cr-Commit-Position: refs/heads/master@{#380042}

Powered by Google App Engine
This is Rietveld 408576698