Chromium Code Reviews| Index: Tools/GardeningServer/scripts/ui/notifications.js |
| diff --git a/Tools/GardeningServer/scripts/ui/notifications.js b/Tools/GardeningServer/scripts/ui/notifications.js |
| index bf3d77e3f7c39e881f5e0aea15fe9e8388ec0c92..34098068adbad6f0282a47dce11391dd86c52832 100644 |
| --- a/Tools/GardeningServer/scripts/ui/notifications.js |
| +++ b/Tools/GardeningServer/scripts/ui/notifications.js |
| @@ -117,8 +117,14 @@ ui.notifications.SuspiciousCommit = base.extends(Cause, { |
| this._addDetail('title', commitData); |
| this._addDetail('author', commitData); |
| this._addDetail('reviewer', commitData); |
| - // FIXME: Add bugID detail. |
| - // this._addDetail('bugID', commitData, bugzilla.bugURL); |
| + this._addDetail('bugID', commitData, |
| + function(bugID) { |
| + return 'http://crbug.com/' + bugID; |
|
apavlov
2014/02/28 13:15:25
Any suggestions on this? Should the base URL resid
|
| + }, |
| + function(value) { |
| + return value.split(/\s*,\s*/); |
| + } |
| + ); |
| }, |
| hasRevision: function(revision) |
| { |
| @@ -134,10 +140,17 @@ ui.notifications.SuspiciousCommit = base.extends(Cause, { |
| span.className = part; |
| if (linkFunction) { |
| - var link = base.createLinkNode(linkFunction(content), content); |
| - span.appendChild(link); |
| - } else |
| + var parts = $.isArray(content) ? content : [content]; |
| + parts.forEach(function(item, index) { |
| + if (index > 0) |
| + span.appendChild(document.createTextNode(', ')); |
| + var link = base.createLinkNode(linkFunction(item), item); |
| + link.className = part + '-item'; |
| + span.appendChild(link); |
| + }); |
| + } else { |
| span.textContent = content; |
| + } |
| } |
| }); |