Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Side by Side Diff: Tools/GardeningServer/scripts/svn-log_unittests.js

Issue 177123013: Garden-o-matic: Display bugs from the commit BUG=... line in commit summary (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Comment addressed Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Tools/GardeningServer/scripts/svn-log.js ('k') | Tools/GardeningServer/scripts/ui.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 "<author>\n" + 74 "<author>\n" +
75 "<name>eseidel@chromium.org</name>\n" + 75 "<name>eseidel@chromium.org</name>\n" +
76 "</author>\n" + 76 "</author>\n" +
77 "<published>2013-09-30T19:36:21Z</published>\n" + 77 "<published>2013-09-30T19:36:21Z</published>\n" +
78 "<link rel='alternate' type='text/html' href='http://blink.lc/blink/commit/?i d=51e5c70050dcb0980eb31f112d0cd948f3ece820'/>\n" + 78 "<link rel='alternate' type='text/html' href='http://blink.lc/blink/commit/?i d=51e5c70050dcb0980eb31f112d0cd948f3ece820'/>\n" +
79 "<id>51e5c70050dcb0980eb31f112d0cd948f3ece820</id>\n" + 79 "<id>51e5c70050dcb0980eb31f112d0cd948f3ece820</id>\n" +
80 "<content type='text'>\n" + 80 "<content type='text'>\n" +
81 "core/platform may not depend on core/ even for testing.\n" + 81 "core/platform may not depend on core/ even for testing.\n" +
82 "\n" + 82 "\n" +
83 "BUG=301947\n" + 83 "BUG=301947\n" +
84 "R=abarth@chromium.org, abarth\n" + 84 "TBR=abarth@chromium.org, abarth\n" +
85 "\n" + 85 "\n" +
86 "Review URL: https://codereview.chromium.org/25284004\n" + 86 "Review URL: https://codereview.chromium.org/25284004\n" +
87 "\n" + 87 "\n" +
88 "git-svn-id: svn://svn.chromium.org/blink/trunk@158544 bbb929c8-8fbe-4397-9db b-9b2b20218538\n" + 88 "git-svn-id: svn://svn.chromium.org/blink/trunk@158544 bbb929c8-8fbe-4397-9db b-9b2b20218538\n" +
89 "</content>\n" + 89 "</content>\n" +
90 "<content type='xhtml'>\n" + 90 "<content type='xhtml'>\n" +
91 "<div xmlns='http://www.w3.org/1999/xhtml'>\n" + 91 "<div xmlns='http://www.w3.org/1999/xhtml'>\n" +
92 "<pre>\n" + 92 "<pre>\n" +
93 "core/platform may not depend on core/ even for testing.\n" + 93 "core/platform may not depend on core/ even for testing.\n" +
94 "\n" + 94 "\n" +
95 "BUG=301947\n" + 95 "BUG=301947\n" +
96 "R=abarth@chromium.org, abarth\n" + 96 "TBR=abarth@chromium.org, abarth\n" +
97 "\n" + 97 "\n" +
98 "Review URL: https://codereview.chromium.org/25284004\n" + 98 "Review URL: https://codereview.chromium.org/25284004\n" +
99 "\n" + 99 "\n" +
100 "git-svn-id: svn://svn.chromium.org/blink/trunk@158544 bbb929c8-8fbe-4397-9db b-9b2b20218538\n" + 100 "git-svn-id: svn://svn.chromium.org/blink/trunk@158544 bbb929c8-8fbe-4397-9db b-9b2b20218538\n" +
101 "</pre>\n" + 101 "</pre>\n" +
102 "</div>\n" + 102 "</div>\n" +
103 "</content>\n" + 103 "</content>\n" +
104 "</entry>\n" + 104 "</entry>\n" +
105 "<entry>\n" + 105 "<entry>\n" +
106 "<title>Update DEPS include_rules after addition of root-level platform direc tory</title>\n" + 106 "<title>Update DEPS include_rules after addition of root-level platform direc tory</title>\n" +
(...skipping 21 matching lines...) Expand all
128 "\n" + 128 "\n" +
129 "R=abarth@chromium.org,abarth\n" + 129 "R=abarth@chromium.org,abarth\n" +
130 "BUG=301947\n" + 130 "BUG=301947\n" +
131 "\n" + 131 "\n" +
132 "Review URL: https://codereview.chromium.org/25275005\n" + 132 "Review URL: https://codereview.chromium.org/25275005\n" +
133 "\n" + 133 "\n" +
134 "git-svn-id: svn://svn.chromium.org/blink/trunk@158543 bbb929c8-8fbe-4397-9db b-9b2b20218538\n" + 134 "git-svn-id: svn://svn.chromium.org/blink/trunk@158543 bbb929c8-8fbe-4397-9db b-9b2b20218538\n" +
135 "</pre>\n" + 135 "</pre>\n" +
136 "</div>\n" + 136 "</div>\n" +
137 "</content>\n" + 137 "</content>\n" +
138 "<entry>\n" +
139 "<title>Mark Skia suppressions for rebasline.</title>\n" +
140 "<updated>2014-02-27T14:44:41Z</updated>\n" +
141 "<author>\n" +
142 "<name>fmalita@chromium.org</name>\n" +
143 "</author>\n" +
144 "<published>2014-02-27T14:44:41Z</published>\n" +
145 "<link rel='alternate' type='text/html' href='http://blink.lc/blink/commit/?i d=35030357db3c0967974273faf5e65fe3d7cc041b'/>\n" +
146 "<id>35030357db3c0967974273faf5e65fe3d7cc041b</id>\n" +
147 "<content type='text'>\n" +
148 "Unreviewed gardening.\n" +
149 "Stray R=123 in the middle...\n" +
150 "\n" +
151 "BUG=/341448,344497\n" +
152 "TBR=robertphillips@google.com\n" +
153 "\n" +
154 "Review URL: https://codereview.chromium.org/183123002\n" +
155 "\n" +
156 "git-svn-id: svn://svn.chromium.org/blink/trunk@168027 bbb929c8-8fbe-4397-9db b-9b2b20218538\n" +
157 "</content>\n" +
158 "<content type='xhtml'>\n" +
159 "<div xmlns='http://www.w3.org/1999/xhtml'>\n" +
160 "<pre>\n" +
161 "Unreviewed gardening.\n" +
162 "Stray R=123 in the middle...\n" +
163 "\n" +
164 "BUG=/341448 , 344497/ \n" +
165 "TBR=robertphillips@google.com\n" +
166 "\n" +
167 "Review URL: https://codereview.chromium.org/183123002\n" +
168 "\n" +
169 "git-svn-id: svn://svn.chromium.org/blink/trunk@168027 bbb929c8-8fbe-4397-9db b-9b2b20218538\n" +
170 "</pre>\n" +
171 "</div>\n" +
172 "</content>\n" +
138 "</entry>\n" + 173 "</entry>\n" +
139 "</feed>\n"; 174 "</feed>\n";
140 175
141 176
142 var kExampleCommitDataList = [{ 177 var kExampleCommitDataList = [{
143 "revision": 158545, 178 "revision": 158545,
144 "title": "Throw SecurityError when setting 'Replaceable' properties cross-or igin.", 179 "title": "Throw SecurityError when setting 'Replaceable' properties cross-or igin.",
145 "time": "2013-09-30T20:22:01Z", 180 "time": "2013-09-30T20:22:01Z",
146 "summary": "This matches Gecko's behavior for these types of properties.", 181 "summary": "This matches Gecko's behavior for these types of properties.",
147 "author": "mkwst@chromium.org", 182 "author": "mkwst@chromium.org",
148 "reviewer": "jochen@chromium.org", 183 "reviewer": "jochen@chromium.org",
149 "bugID": 17325, 184 "bugID": [17325],
150 "revertedRevision": undefined 185 "revertedRevision": undefined
151 }, 186 },
152 { 187 {
153 "revision": 158544, 188 "revision": 158544,
154 "title": "Fix one more layering violation caught by check-blink-deps", 189 "title": "Fix one more layering violation caught by check-blink-deps",
155 "time": "2013-09-30T19:36:21Z", 190 "time": "2013-09-30T19:36:21Z",
156 "summary": "core/platform may not depend on core/ even for testing.", 191 "summary": "core/platform may not depend on core/ even for testing.",
157 "author": "eseidel@chromium.org", 192 "author": "eseidel@chromium.org",
158 "reviewer": "abarth@chromium.org, abarth", 193 "reviewer": "abarth@chromium.org, abarth",
159 "bugID": 301947, 194 "bugID": [301947],
160 "revertedRevision": undefined 195 "revertedRevision": undefined
161 }, 196 },
162 { 197 {
163 "revision": 158543, 198 "revision": 158543,
164 "title": "Update DEPS include_rules after addition of root-level platform di rectory", 199 "title": "Update DEPS include_rules after addition of root-level platform di rectory",
165 "time": "2013-09-30T19:28:49Z", 200 "time": "2013-09-30T19:28:49Z",
166 "summary": "These were all failures noticed when running check-blink-deps", 201 "summary": "These were all failures noticed when running check-blink-deps",
167 "author": "eseidel@chromium.org", 202 "author": "eseidel@chromium.org",
168 "reviewer": "abarth@chromium.org, abarth", 203 "reviewer": "abarth@chromium.org, abarth",
169 "bugID": 301947, 204 "bugID": [301947],
205 "revertedRevision": undefined
206 },
207 {
208 "revision": 168027,
209 "title": "Mark Skia suppressions for rebasline.",
210 "time": "2014-02-27T14:44:41Z",
211 "summary": "Unreviewed gardening.",
212 "author": "fmalita@chromium.org",
213 "reviewer": "robertphillips@google.com",
214 "bugID": [341448, 344497],
170 "revertedRevision": undefined 215 "revertedRevision": undefined
171 } 216 }
172 ]; 217 ];
173 218
174 test("changesetURL", 1, function() { 219 test("changesetURL", 1, function() {
175 equals(trac.changesetURL(1234), "http://src.chromium.org/viewvc/blink?view=r ev&revision=1234"); 220 equals(trac.changesetURL(1234), "http://src.chromium.org/viewvc/blink?view=r ev&revision=1234");
176 }); 221 });
177 222
178 asyncTest("recentCommitData", 3, function() { 223 asyncTest("recentCommitData", 3, function() {
179 var simulator = new NetworkSimulator(); 224 var simulator = new NetworkSimulator();
(...skipping 10 matching lines...) Expand all
190 $.each(commitDataList, function(index, commitData) { 235 $.each(commitDataList, function(index, commitData) {
191 // Including the entire message makes the deepEqual below to unw ieldy. 236 // Including the entire message makes the deepEqual below to unw ieldy.
192 delete commitData.message; 237 delete commitData.message;
193 }); 238 });
194 deepEqual(commitDataList, kExampleCommitDataList); 239 deepEqual(commitDataList, kExampleCommitDataList);
195 }); 240 });
196 }).then(start); 241 }).then(start);
197 }); 242 });
198 243
199 })(); 244 })();
OLDNEW
« no previous file with comments | « Tools/GardeningServer/scripts/svn-log.js ('k') | Tools/GardeningServer/scripts/ui.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698