Garden-o-matic: Display bugs from the commit BUG=... line in commit summary

Tools/GardeningServer/scripts/ui/notifications.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 99 matching lines @@
 
 ui.notifications.SuspiciousCommit = base.extends(Cause, {
     init: function(commitData)
     {
         this._revision = commitData.revision;
         this._description.appendChild(base.createLinkNode(trac.changesetURL(commitData.revision), commitData.revision));
         this._details = this._description.appendChild(document.createElement('span'));
         this._addDetail('title', commitData);
         this._addDetail('author', commitData);
         this._addDetail('reviewer', commitData);
-        // FIXME: Add bugID detail.
-        // this._addDetail('bugID', commitData, bugzilla.bugURL);
+        this._addDetail('bugID', commitData,
+            function(bugID) {
+                return 'http://crbug.com/' + bugID;

[apavlov, 2014/02/28 13:15:25]

Any suggestions on this? Should the base URL reside somewhere as a constant
instead? Do we want to somehow display the bug summary on hover/etc?

+            },
+            function(value) {
+                return value.split(/\s*,\s*/);
+            }
+        );
     },
     hasRevision: function(revision)
     {
         return this._revision == revision;
     },
     _addDetail: function(part, commitData, linkFunction)
     {
         var content = commitData[part];
         if (!content)
             return;
 
         var span = this._details.appendChild(document.createElement('span'));
         span.className = part;
         
         if (linkFunction) {
-            var link = base.createLinkNode(linkFunction(content), content);
-            span.appendChild(link);
-        } else
+            var parts = $.isArray(content) ? content : [content];
+            parts.forEach(function(item, index) {
+                if (index > 0)
+                    span.appendChild(document.createTextNode(', '));
+                var link = base.createLinkNode(linkFunction(item), item);
+                link.className = part + '-item';
+                span.appendChild(link);
+            });
+        } else {
             span.textContent = content;
+        }
     }
 });
 
 ui.notifications.Failure = base.extends(ui.notifications.Notification, {
     init: function()
     {
         this._time = this._how.appendChild(new ui.RelativeTime());
         this._problem = this._what.appendChild(document.createElement('div'));
         this._problem.className = 'problem';
         this._effects = this._problem.appendChild(document.createElement('ul'));
@@ skipping 104 matching lines @@
         $(this._effects).empty().append(Object.keys(failuresList).map(function(builderName) {
             var effect = document.createElement('li');
             effect.className = 'builder';
             effect.appendChild(new ui.failures.Builder(builderName, failuresList[builderName]));
             return effect;
         }));
     }
 });
 
 })();