Issue 177123002: Clear any open dialogs when the renderer process goes away.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 177123002: Clear any open dialogs when the renderer process goes away. (Closed)

Created:
6 years, 10 months ago by Charlie Reis

Modified:
6 years, 10 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Clear any open dialogs when the renderer process goes away. BUG=343625 TEST=See bug for repro steps. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253006

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -0 lines)			Patch
	M	chrome/browser/ui/browser_browsertest.cc	View		1 chunk	+32 lines, -0 lines	0 comments	Download
	M	content/browser/web_contents/web_contents_impl.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

Charlie Reis

Darin, can you take a look? We were leaving dialogs open when a renderer crashed, ...

6 years, 10 months ago (2014-02-24 17:48:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/177123002/1

6 years, 10 months ago (2014-02-24 20:36:23 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/177123002/1

6 years, 10 months ago (2014-02-24 21:17:07 UTC) #5

Charlie Reis

6 years, 10 months ago (2014-02-24 22:10:23 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 manually as r253006 (presubmit successful).