chrome/browser/ui/input_method/input_method_engine.h - Issue 1771173002: Implement input.ime.sendKeyEvents API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/input_method/input_method_engine.h

Issue 1771173002: Implement input.ime.sendKeyEvents API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Shu's comment and update implementation on Windows. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/input_method/input_method_engine.h

diff --git a/chrome/browser/ui/input_method/input_method_engine.h b/chrome/browser/ui/input_method/input_method_engine.h

index 14e5ac5eaa779827fb026d8ffd73107a517fc598..0d3fe92a04184c967b2daf7d0100c0c3d684f34b 100644

--- a/chrome/browser/ui/input_method/input_method_engine.h

+++ b/chrome/browser/ui/input_method/input_method_engine.h

@@ -26,8 +26,6 @@ class InputMethodEngine : public InputMethodEngineBase,

~InputMethodEngine() override;

// ui::IMEEngineHandlerInterface:

- bool SendKeyEvents(int context_id,

- const std::vector<KeyboardEvent>& events) override;

bool IsActive() const override;

std::string GetExtensionId() const override;

@@ -53,6 +51,7 @@ class InputMethodEngine : public InputMethodEngineBase,

bool is_visible) override;

void CommitTextToInputContext(int context_id,

const std::string& text) override;

+ bool SendKeyEvent(ui::KeyEvent* ui_event) override;

// ui::ImeWindowObserver:

void OnWindowDestroyed(ui::ImeWindow* ime_window) override;