Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: chrome/browser/ui/input_method/input_method_engine_base.h

Issue 1771173002: Implement input.ime.sendKeyEvents API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix patch conflict. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/input_method/input_method_engine_base.h
diff --git a/chrome/browser/ui/input_method/input_method_engine_base.h b/chrome/browser/ui/input_method/input_method_engine_base.h
index 1ca4a1620fb024d3bc189230e01c677ea323bae4..dcf5d7c224001ef65a2a638850a648b59a7bf8f6 100644
--- a/chrome/browser/ui/input_method/input_method_engine_base.h
+++ b/chrome/browser/ui/input_method/input_method_engine_base.h
@@ -154,8 +154,7 @@ class InputMethodEngineBase : virtual public ui::IMEEngineHandlerInterface {
bool IsInterestedInKeyEvent() const override;
// Send the sequence of key events.
- virtual bool SendKeyEvents(int context_id,
- const std::vector<KeyboardEvent>& events) = 0;
+ bool SendKeyEvents(int context_id, const std::vector<KeyboardEvent>& events);
// Set the current composition and associated properties.
bool SetComposition(int context_id,
@@ -186,6 +185,8 @@ class InputMethodEngineBase : virtual public ui::IMEEngineHandlerInterface {
// Notifies InputContextHanlder to commit |text|.
virtual void CommitTextToInputContext(int context_id,
const std::string& text) = 0;
+ // Sends the key event to the window tree host.
+ virtual bool SendKeyEvent(ui::KeyEvent* ui_event) = 0;
Devlin 2016/03/10 23:21:14 Could this be a const ui::KeyEvent&? If not, can
Azure Wei 2016/03/11 07:29:01 DCHECKs were added. We need the set the state of t
ui::TextInputType current_input_type_;

Powered by Google App Engine
This is Rietveld 408576698