Minor fixes to the capturer and the processor

Minor fixes to the capturer and the processor

NOTRY=true

BUG=264611
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255346

[no longer working on chromium, 2014-03-05 19:43:44]

Henrik, PTAL.

Thanks,
SX

[Henrik Grunell, 2014-03-06 07:59:09]

https://codereview.chromium.org/177113012/diff/1/content/renderer/media/media...
File content/renderer/media/media_stream_audio_processor.cc (right):

https://codereview.chromium.org/177113012/diff/1/content/renderer/media/media...
content/renderer/media/media_stream_audio_processor.cc:274:
!enable_experimental_ns) {
I can't say if this is correct, since I don't understand the reason for the
change. :)

[no longer working on chromium, 2014-03-06 08:35:13]

https://codereview.chromium.org/177113012/diff/1/content/renderer/media/media...
File content/renderer/media/media_stream_audio_processor.cc (right):

https://codereview.chromium.org/177113012/diff/1/content/renderer/media/media...
content/renderer/media/media_stream_audio_processor.cc:168:
audio_source->SwapChannels(0, 1);
FYI, audio_mirroring is done without the APM.

https://codereview.chromium.org/177113012/diff/1/content/renderer/media/media...
content/renderer/media/media_stream_audio_processor.cc:274:
!enable_experimental_ns) {
On 2014/03/06 07:59:10, Henrik Grunell wrote:
> I can't say if this is correct, since I don't understand the reason for the
> change. :)

I can confirm that this is correct, since the mirroring is done without the APM,
I pointed out where the mirroring is done.

[Henrik Grunell, 2014-03-06 09:50:08]

lgtm

https://codereview.chromium.org/177113012/diff/1/content/renderer/media/media...
File content/renderer/media/media_stream_audio_processor.cc (right):

https://codereview.chromium.org/177113012/diff/1/content/renderer/media/media...
content/renderer/media/media_stream_audio_processor.cc:274:
!enable_experimental_ns) {
On 2014/03/06 08:35:14, xians1 wrote:
> On 2014/03/06 07:59:10, Henrik Grunell wrote:
> > I can't say if this is correct, since I don't understand the reason for the
> > change. :)
> 
> I can confirm that this is correct, since the mirroring is done without the
APM,
> I pointed out where the mirroring is done.

OK, thanks for clarifying.

[no longer working on chromium, 2014-03-06 09:51:36]

The CQ bit was checked by xians@chromium.org

[commit-bot: I haz the power, 2014-03-06 09:51:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xians@chromium.org/177113012/1

[commit-bot: I haz the power, 2014-03-06 11:48:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 11:48:54]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[no longer working on chromium, 2014-03-06 12:31:49]

The CQ bit was checked by xians@chromium.org

[commit-bot: I haz the power, 2014-03-06 12:31:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xians@chromium.org/177113012/1

[commit-bot: I haz the power, 2014-03-06 14:28:35]

Change committed as 255346