Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1355)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 177113010: Disable redirects in component builds (for now at least). (Closed)

Created:
6 years, 9 months ago by Cait (Slow)
Modified:
6 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org, gab, robertshield
Visibility:
Public.

Description

Disable redirects in component builds (for now at least). BUG=349423 R=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255127

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M base/base.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Cait (Slow)
Mark: PTAL. Unfortunately, https://codereview.chromium.org/183773003/ didn't fully solve the issues with redirects in component builds. Disabling ...
6 years, 9 months ago (2014-03-05 15:00:01 UTC) #1
Mark Mentovai
LGTM
6 years, 9 months ago (2014-03-05 15:07:46 UTC) #2
Cait (Slow)
The CQ bit was checked by caitkp@chromium.org
6 years, 9 months ago (2014-03-05 15:44:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/177113010/1
6 years, 9 months ago (2014-03-05 15:45:02 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 17:03:45 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=275302
6 years, 9 months ago (2014-03-05 17:03:46 UTC) #6
Cait (Slow)
The CQ bit was checked by caitkp@chromium.org
6 years, 9 months ago (2014-03-05 17:20:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/177113010/1
6 years, 9 months ago (2014-03-05 17:21:07 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 19:37:53 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=275480
6 years, 9 months ago (2014-03-05 19:37:53 UTC) #10
Cait (Slow)
6 years, 9 months ago (2014-03-05 20:00:54 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 manually as r255127 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698