ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc - Issue 177113009: Support non-SFI mode in NaCl manifest file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc

Issue 177113009: Support non-SFI mode in NaCl manifest file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc

diff --git a/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc b/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc

index 3909777f057c30ba706c2d8c14ab435b1f6c9293..29ada4768ef36c1bf1b8179c865ff4950ddb6cd2 100644

--- a/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc

+++ b/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc

@@ -42,10 +42,12 @@ class PnaclManifest : public Manifest {

virtual bool GetProgramURL(nacl::string* full_url,

PnaclOptions* pnacl_options,

+ bool* uses_nonsfi_mode,

ErrorInfo* error_info) const {

// Does not contain program urls.

UNREFERENCED_PARAMETER(full_url);

UNREFERENCED_PARAMETER(pnacl_options);

+ UNREFERENCED_PARAMETER(uses_nonsfi_mode);

UNREFERENCED_PARAMETER(error_info);

PLUGIN_PRINTF(("PnaclManifest does not contain a program\n"));

error_info->SetReport(PP_NACL_ERROR_MANIFEST_GET_NEXE_URL,