Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1771073002: SkPDF: s/SkAutoTUnref/sk_sp/g (Closed)

Created:
4 years, 9 months ago by hal.canary
Modified:
4 years, 9 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -97 lines) Patch
M src/doc/SkDocument_PDF.cpp View 7 chunks +14 lines, -14 lines 0 comments Download
M src/pdf/SkPDFBitmap.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M src/pdf/SkPDFCanon.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFDevice.cpp View 17 chunks +20 lines, -20 lines 0 comments Download
M src/pdf/SkPDFFont.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/pdf/SkPDFFont.cpp View 18 chunks +24 lines, -24 lines 0 comments Download
M src/pdf/SkPDFFormXObject.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/pdf/SkPDFGraphicState.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M src/pdf/SkPDFMetadata.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pdf/SkPDFResourceDict.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/pdf/SkPDFShader.cpp View 7 chunks +12 lines, -12 lines 0 comments Download
M src/pdf/SkPDFTypes.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771073002/1
4 years, 9 months ago (2016-03-07 22:14:38 UTC) #4
hal.canary
doing this in the right order.
4 years, 9 months ago (2016-03-07 22:20:51 UTC) #7
hal.canary
doing this in the right order.
4 years, 9 months ago (2016-03-07 22:20:51 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-07 22:25:49 UTC) #10
bungeman-skia
lgtm
4 years, 9 months ago (2016-03-07 22:54:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771073002/1
4 years, 9 months ago (2016-03-07 22:56:33 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 22:57:53 UTC) #16
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/48810a023705ffac466adb93efdb3861cf2e197a

Powered by Google App Engine
This is Rietveld 408576698