Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1771043004: tbody.deleteRow(-1) should never throw an exception (Closed)

Created:
4 years, 9 months ago by ramya.v
Modified:
4 years, 9 months ago
Reviewers:
tkent
CC:
chromium-reviews, blink-reviews, tfarina, blink-reviews-w3ctests_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tbody.deleteRow(-1) should never throw an exception As per spec https://html.spec.whatwg.org/multipage/tables.html#dom-tbody-deleterow If index is -1, remove the last element in the rows collection from its parent. Should not throw exception in this case if row is empty. BUG=592817 Committed: https://crrev.com/0c4a630b476aa829cacd0b8fb7d716d5d993692e Cr-Commit-Position: refs/heads/master@{#379771}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
D third_party/WebKit/LayoutTests/imported/web-platform-tests/html/semantics/tabular-data/the-tbody-element/deleteRow-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTableSectionElement.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
ramya.v
PTAL! Thanks
4 years, 9 months ago (2016-03-08 05:36:45 UTC) #2
tkent
> parent. Should not throw exception in this case if row is empty. Oh, I ...
4 years, 9 months ago (2016-03-08 05:48:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771043004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771043004/1
4 years, 9 months ago (2016-03-08 05:51:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 07:11:40 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 07:12:52 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c4a630b476aa829cacd0b8fb7d716d5d993692e
Cr-Commit-Position: refs/heads/master@{#379771}

Powered by Google App Engine
This is Rietveld 408576698