Add atomic sequence number to ChannelIDService and check that in URLRequestHttpJob logging

Add atomic sequence number to ChannelIDService and check that in URLRequestHttpJob logging

BUG=548423
Committed: https://crrev.com/09ccd50a4e3d7575cfda2946338100a6ef48e58a
Cr-Commit-Position: refs/heads/master@{#380299}

[nharper, 2016-03-07 19:43:25]

add values to histograms.xml

[nharper, 2016-03-07 19:53:41]

Patchset #3 (id:40001) has been deleted

[nharper, 2016-03-08 00:07:11]

Patchset #4 (id:80001) has been deleted

[nharper, 2016-03-08 00:07:25]

Patchset #3 (id:60001) has been deleted

[nharper, 2016-03-09 20:14:12]

Patchset #3 (id:100001) has been deleted

[nharper, 2016-03-09 20:23:54]

Description was changed from

==========
Add atomic sequence number to ChannelIDService and check that in
URLRequestHttpJob logging
==========

to

==========
Add atomic sequence number to ChannelIDService and check that in
URLRequestHttpJob logging

BUG=548423
==========

[nharper, 2016-03-09 20:24:21]

nharper@chromium.org changed reviewers:
+ mattm@chromium.org

[mattm, 2016-03-09 21:33:01]

https://codereview.chromium.org/1770983002/diff/140001/net/ssl/channel_id_ser...
File net/ssl/channel_id_service.h (right):

https://codereview.chromium.org/1770983002/diff/140001/net/ssl/channel_id_ser...
net/ssl/channel_id_service.h:134: int GetUniqueID() { return id_; }
const method

https://codereview.chromium.org/1770983002/diff/140001/net/ssl/channel_id_ser...
net/ssl/channel_id_service.h:178: int id_;
can this be const?

https://codereview.chromium.org/1770983002/diff/140001/net/url_request/url_re...
File net/url_request/url_request_http_job.cc (right):

https://codereview.chromium.org/1770983002/diff/140001/net/url_request/url_re...
net/url_request/url_request_http_job.cc:77: CID_PERSISTENT_COOKIE_PERSISTENT =
3,
Comment out which of these are no longer used

https://codereview.chromium.org/1770983002/diff/140001/net/url_request/url_re...
net/url_request/url_request_http_job.cc:109: ephemerality =
CID_PERSISTENT_COOKIE_PERSISTENT;
this looks wrong..

Above,CID_EPHEMERAL_COOKIE_EPHEMERAL is no longer used since it was replaced
with EPHEMERAL_MATCH and EPHEMERAL_MISMATCH. That makes sense.
 
Here CID_PERSISTENT_COOKIE_PERSISTENT is still used, and it looks like the
PERSISTENT_MATCH / PERSISTENT_MISMATCH condition replaces
CID_PERSISTENT_COOKIE_EPHEMERAL? Why is that?

https://codereview.chromium.org/1770983002/diff/140001/tools/metrics/histogra...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1770983002/diff/140001/tools/metrics/histogra...
tools/metrics/histograms/histograms.xml:82507: +  <int value="10"
label="PERSISTENT_MISMATCH"/>
add notes about old values that are not used anymore, etc.

[nharper, 2016-03-09 21:52:08]

https://codereview.chromium.org/1770983002/diff/140001/net/ssl/channel_id_ser...
File net/ssl/channel_id_service.h (right):

https://codereview.chromium.org/1770983002/diff/140001/net/ssl/channel_id_ser...
net/ssl/channel_id_service.h:134: int GetUniqueID() { return id_; }
On 2016/03/09 21:33:01, mattm wrote:
> const method

Done.

https://codereview.chromium.org/1770983002/diff/140001/net/ssl/channel_id_ser...
net/ssl/channel_id_service.h:178: int id_;
On 2016/03/09 21:33:01, mattm wrote:
> can this be const?

Yes. Done.

https://codereview.chromium.org/1770983002/diff/140001/net/url_request/url_re...
File net/url_request/url_request_http_job.cc (right):

https://codereview.chromium.org/1770983002/diff/140001/net/url_request/url_re...
net/url_request/url_request_http_job.cc:77: CID_PERSISTENT_COOKIE_PERSISTENT =
3,
On 2016/03/09 21:33:01, mattm wrote:
> Comment out which of these are no longer used

Done.

https://codereview.chromium.org/1770983002/diff/140001/net/url_request/url_re...
net/url_request/url_request_http_job.cc:109: ephemerality =
CID_PERSISTENT_COOKIE_PERSISTENT;
On 2016/03/09 21:33:01, mattm wrote:
> this looks wrong..
> 
> Above,CID_EPHEMERAL_COOKIE_EPHEMERAL is no longer used since it was replaced
> with EPHEMERAL_MATCH and EPHEMERAL_MISMATCH. That makes sense.
>  
> Here CID_PERSISTENT_COOKIE_PERSISTENT is still used, and it looks like the
> PERSISTENT_MATCH / PERSISTENT_MISMATCH condition replaces
> CID_PERSISTENT_COOKIE_EPHEMERAL? Why is that?

I goofed when making this half of the change. Your expectation of what it should
be is what it should be.

https://codereview.chromium.org/1770983002/diff/140001/tools/metrics/histogra...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1770983002/diff/140001/tools/metrics/histogra...
tools/metrics/histograms/histograms.xml:82507: +  <int value="10"
label="PERSISTENT_MISMATCH"/>
On 2016/03/09 21:33:01, mattm wrote:
> add notes about old values that are not used anymore, etc.

Done.

[mattm, 2016-03-09 22:26:24]

lgtm

[nharper, 2016-03-09 22:27:20]

nharper@chromium.org changed reviewers:
+ rkaplow@chromium.org

[rkaplow, 2016-03-09 22:32:54]

lgtm

[nharper, 2016-03-09 22:34:27]

The CQ bit was checked by nharper@chromium.org

[commit-bot: I haz the power, 2016-03-09 22:34:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770983002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770983002/160001

[commit-bot: I haz the power, 2016-03-10 01:54:36]

Description was changed from

==========
Add atomic sequence number to ChannelIDService and check that in
URLRequestHttpJob logging

BUG=548423
==========

to

==========
Add atomic sequence number to ChannelIDService and check that in
URLRequestHttpJob logging

BUG=548423
==========

[commit-bot: I haz the power, 2016-03-10 01:54:37]

Committed patchset #5 (id:160001)

[commit-bot: I haz the power, 2016-03-10 01:55:37]

Description was changed from

==========
Add atomic sequence number to ChannelIDService and check that in
URLRequestHttpJob logging

BUG=548423
==========

to

==========
Add atomic sequence number to ChannelIDService and check that in
URLRequestHttpJob logging

BUG=548423

Committed: https://crrev.com/09ccd50a4e3d7575cfda2946338100a6ef48e58a
Cr-Commit-Position: refs/heads/master@{#380299}
==========

[commit-bot: I haz the power, 2016-03-10 01:55:38]

Patchset 5 (id:??) landed as
https://crrev.com/09ccd50a4e3d7575cfda2946338100a6ef48e58a
Cr-Commit-Position: refs/heads/master@{#380299}