Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1770953004: Remove xfa/src/fwl/src and move code up a level. (Closed)

Created:
4 years, 9 months ago by dsinclair
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove xfa/src/fwl/src and move code up a level. This Cl moves the xfa/src/fwl/src code up to the previously empty parent directory and removes xfa/src/fwl/src. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/6f6388fee1fdb4bec57549fe87a0833b2b20bebe

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+457 lines, -26863 lines) Patch
M BUILD.gn View 1 chunk +79 lines, -79 lines 2 comments Download
M xfa.gyp View 1 chunk +79 lines, -79 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_picturebox.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/basewidget/fwl_pushbutton.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/basewidget/fwl_scrollbar.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/basewidget/fwl_spinbutton.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/core/fwl_content.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/core/fwl_panel.h View 1 chunk +1 line, -1 line 0 comments Download
A + xfa/src/fwl/basewidget/fwl_barcodeimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_barcodeimp.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_caretimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_caretimp.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_checkboximp.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_checkboximp.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_comboboximp.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_comboboximp.cpp View 7 chunks +21 lines, -25 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_datetimepickerimp.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_datetimepickerimp.cpp View 4 chunks +13 lines, -16 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_editimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_editimp.cpp View 3 chunks +11 lines, -12 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_formproxyimp.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_formproxyimp.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_listboximp.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_listboximp.cpp View 2 chunks +7 lines, -8 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_monthcalendarimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_monthcalendarimp.cpp View 2 chunks +5 lines, -6 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_pictureboximp.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_pictureboximp.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_pushbuttonimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_pushbuttonimp.cpp View 2 chunks +5 lines, -6 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_scrollbarimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_scrollbarimp.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_spinbuttonimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_spinbuttonimp.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_tooltipctrlimp.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + xfa/src/fwl/basewidget/fwl_tooltipctrlimp.cpp View 2 chunks +7 lines, -8 lines 0 comments Download
A + xfa/src/fwl/basewidget/fxmath_barcodeimp.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + xfa/src/fwl/basewidget/fxmath_barcodeimp.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + xfa/src/fwl/core/fwl_appimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/core/fwl_appimp.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + xfa/src/fwl/core/fwl_contentimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/core/fwl_contentimp.cpp View 2 chunks +7 lines, -8 lines 0 comments Download
A + xfa/src/fwl/core/fwl_formimp.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + xfa/src/fwl/core/fwl_formimp.cpp View 3 chunks +11 lines, -13 lines 0 comments Download
A + xfa/src/fwl/core/fwl_gridimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/core/fwl_gridimp.cpp View 2 chunks +7 lines, -8 lines 0 comments Download
A + xfa/src/fwl/core/fwl_noteimp.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + xfa/src/fwl/core/fwl_noteimp.cpp View 2 chunks +43 lines, -43 lines 0 comments Download
A + xfa/src/fwl/core/fwl_panelimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/core/fwl_panelimp.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + xfa/src/fwl/core/fwl_sdadapterimp.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/core/fwl_targetimp.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + xfa/src/fwl/core/fwl_targetimp.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
A + xfa/src/fwl/core/fwl_threadimp.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + xfa/src/fwl/core/fwl_threadimp.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/core/fwl_timerimp.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + xfa/src/fwl/core/fwl_widgetimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/core/fwl_widgetimp.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
A + xfa/src/fwl/core/fwl_widgetmgrimp.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + xfa/src/fwl/core/fwl_widgetmgrimp.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
A + xfa/src/fwl/lightwidget/app.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + xfa/src/fwl/lightwidget/barcode.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + xfa/src/fwl/lightwidget/caret.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + xfa/src/fwl/lightwidget/checkbox.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + xfa/src/fwl/lightwidget/combobox.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + xfa/src/fwl/lightwidget/datetimepicker.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + xfa/src/fwl/lightwidget/edit.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + xfa/src/fwl/lightwidget/listbox.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + xfa/src/fwl/lightwidget/picturebox.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + xfa/src/fwl/lightwidget/pushbutton.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + xfa/src/fwl/lightwidget/scrollbar.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + xfa/src/fwl/lightwidget/theme.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + xfa/src/fwl/lightwidget/tooltipctrl.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
A + xfa/src/fwl/lightwidget/widget.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_barcodeimp.h View 1 chunk +0 lines, -54 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_barcodeimp.cpp View 1 chunk +0 lines, -221 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_caretimp.h View 1 chunk +0 lines, -67 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_caretimp.cpp View 1 chunk +0 lines, -157 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_checkboximp.h View 1 chunk +0 lines, -64 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_checkboximp.cpp View 1 chunk +0 lines, -555 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_comboboximp.h View 1 chunk +0 lines, -237 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp View 1 chunk +0 lines, -1823 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_datetimepickerimp.h View 1 chunk +0 lines, -235 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_datetimepickerimp.cpp View 1 chunk +0 lines, -1164 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_editimp.h View 1 chunk +0 lines, -208 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_editimp.cpp View 1 chunk +0 lines, -2152 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_formproxyimp.h View 1 chunk +0 lines, -42 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_formproxyimp.cpp View 1 chunk +0 lines, -55 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_listboximp.h View 1 chunk +0 lines, -121 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_listboximp.cpp View 1 chunk +0 lines, -1242 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_monthcalendarimp.h View 1 chunk +0 lines, -243 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_monthcalendarimp.cpp View 1 chunk +0 lines, -1099 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_pictureboximp.h View 1 chunk +0 lines, -53 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_pictureboximp.cpp View 1 chunk +0 lines, -151 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_pushbuttonimp.h View 1 chunk +0 lines, -65 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_pushbuttonimp.cpp View 1 chunk +0 lines, -551 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_scrollbarimp.h View 1 chunk +0 lines, -139 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_scrollbarimp.cpp View 1 chunk +0 lines, -805 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_spinbuttonimp.h View 1 chunk +0 lines, -69 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_spinbuttonimp.cpp View 1 chunk +0 lines, -429 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_tooltipctrlimp.h View 1 chunk +0 lines, -86 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fwl_tooltipctrlimp.cpp View 1 chunk +0 lines, -294 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fxmath_barcodeimp.h View 1 chunk +0 lines, -56 lines 0 comments Download
D xfa/src/fwl/src/basewidget/fxmath_barcodeimp.cpp View 1 chunk +0 lines, -385 lines 0 comments Download
D xfa/src/fwl/src/core/fwl_appimp.h View 1 chunk +0 lines, -38 lines 0 comments Download
D xfa/src/fwl/src/core/fwl_appimp.cpp View 1 chunk +0 lines, -114 lines 0 comments Download
D xfa/src/fwl/src/core/fwl_contentimp.h View 1 chunk +0 lines, -35 lines 0 comments Download
D xfa/src/fwl/src/core/fwl_contentimp.cpp View 1 chunk +0 lines, -95 lines 0 comments Download
D xfa/src/fwl/src/core/fwl_formimp.h View 1 chunk +0 lines, -193 lines 0 comments Download
D xfa/src/fwl/src/core/fwl_formimp.cpp View 1 chunk +0 lines, -1177 lines 0 comments Download
D xfa/src/fwl/src/core/fwl_gridimp.h View 1 chunk +0 lines, -197 lines 0 comments Download
D xfa/src/fwl/src/core/fwl_gridimp.cpp View 1 chunk +0 lines, -1379 lines 0 comments Download
D xfa/src/fwl/src/core/fwl_noteimp.h View 1 chunk +0 lines, -157 lines 0 comments Download
D xfa/src/fwl/src/core/fwl_noteimp.cpp View 1 chunk +0 lines, -1097 lines 0 comments Download
D xfa/src/fwl/src/core/fwl_panelimp.h View 1 chunk +0 lines, -32 lines 0 comments Download
D xfa/src/fwl/src/core/fwl_panelimp.cpp View 1 chunk +0 lines, -152 lines 0 comments Download
D xfa/src/fwl/src/core/fwl_sdadapterimp.cpp View 1 chunk +0 lines, -175 lines 0 comments Download
D xfa/src/fwl/src/core/fwl_targetimp.h View 1 chunk +0 lines, -27 lines 0 comments Download
D xfa/src/fwl/src/core/fwl_targetimp.cpp View 1 chunk +0 lines, -45 lines 0 comments Download
D xfa/src/fwl/src/core/fwl_threadimp.h View 1 chunk +0 lines, -40 lines 0 comments Download
D xfa/src/fwl/src/core/fwl_threadimp.cpp View 1 chunk +0 lines, -38 lines 0 comments Download
D xfa/src/fwl/src/core/fwl_timerimp.cpp View 1 chunk +0 lines, -36 lines 0 comments Download
D xfa/src/fwl/src/core/fwl_widgetimp.h View 1 chunk +0 lines, -162 lines 0 comments Download
D xfa/src/fwl/src/core/fwl_widgetimp.cpp View 1 chunk +0 lines, -1101 lines 0 comments Download
D xfa/src/fwl/src/core/fwl_widgetmgrimp.h View 1 chunk +0 lines, -170 lines 0 comments Download
D xfa/src/fwl/src/core/fwl_widgetmgrimp.cpp View 1 chunk +0 lines, -1075 lines 0 comments Download
D xfa/src/fwl/src/lightwidget/app.cpp View 1 chunk +0 lines, -33 lines 0 comments Download
D xfa/src/fwl/src/lightwidget/barcode.cpp View 1 chunk +0 lines, -45 lines 0 comments Download
D xfa/src/fwl/src/lightwidget/caret.cpp View 1 chunk +0 lines, -47 lines 0 comments Download
D xfa/src/fwl/src/lightwidget/checkbox.cpp View 1 chunk +0 lines, -57 lines 0 comments Download
D xfa/src/fwl/src/lightwidget/combobox.cpp View 1 chunk +0 lines, -370 lines 0 comments Download
D xfa/src/fwl/src/lightwidget/datetimepicker.cpp View 1 chunk +0 lines, -144 lines 0 comments Download
D xfa/src/fwl/src/lightwidget/edit.cpp View 1 chunk +0 lines, -210 lines 0 comments Download
D xfa/src/fwl/src/lightwidget/listbox.cpp View 1 chunk +0 lines, -302 lines 0 comments Download
D xfa/src/fwl/src/lightwidget/picturebox.cpp View 1 chunk +0 lines, -119 lines 0 comments Download
D xfa/src/fwl/src/lightwidget/pushbutton.cpp View 1 chunk +0 lines, -56 lines 0 comments Download
D xfa/src/fwl/src/lightwidget/scrollbar.cpp View 1 chunk +0 lines, -93 lines 0 comments Download
D xfa/src/fwl/src/lightwidget/theme.cpp View 1 chunk +0 lines, -135 lines 0 comments Download
D xfa/src/fwl/src/lightwidget/tooltipctrl.cpp View 1 chunk +0 lines, -111 lines 0 comments Download
D xfa/src/fwl/src/lightwidget/widget.cpp View 1 chunk +0 lines, -318 lines 0 comments Download
D xfa/src/fwl/src/theme/barcodetp.cpp View 1 chunk +0 lines, -42 lines 0 comments Download
D xfa/src/fwl/src/theme/carettp.cpp View 1 chunk +0 lines, -49 lines 0 comments Download
D xfa/src/fwl/src/theme/checkboxtp.cpp View 1 chunk +0 lines, -532 lines 0 comments Download
D xfa/src/fwl/src/theme/comboboxtp.cpp View 1 chunk +0 lines, -156 lines 0 comments Download
D xfa/src/fwl/src/theme/datetimepickertp.cpp View 1 chunk +0 lines, -138 lines 0 comments Download
D xfa/src/fwl/src/theme/edittp.cpp View 1 chunk +0 lines, -89 lines 0 comments Download
D xfa/src/fwl/src/theme/formtp.cpp View 1 chunk +0 lines, -893 lines 0 comments Download
D xfa/src/fwl/src/theme/listboxtp.cpp View 1 chunk +0 lines, -101 lines 0 comments Download
D xfa/src/fwl/src/theme/monthcalendartp.cpp View 1 chunk +0 lines, -582 lines 0 comments Download
D xfa/src/fwl/src/theme/pictureboxtp.cpp View 1 chunk +0 lines, -36 lines 0 comments Download
D xfa/src/fwl/src/theme/pushbuttontp.cpp View 1 chunk +0 lines, -157 lines 0 comments Download
D xfa/src/fwl/src/theme/scrollbartp.cpp View 1 chunk +0 lines, -377 lines 0 comments Download
D xfa/src/fwl/src/theme/widgettp.cpp View 1 chunk +0 lines, -840 lines 0 comments Download
A + xfa/src/fwl/theme/barcodetp.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + xfa/src/fwl/theme/carettp.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + xfa/src/fwl/theme/checkboxtp.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + xfa/src/fwl/theme/comboboxtp.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + xfa/src/fwl/theme/datetimepickertp.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + xfa/src/fwl/theme/edittp.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + xfa/src/fwl/theme/formtp.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + xfa/src/fwl/theme/listboxtp.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + xfa/src/fwl/theme/monthcalendartp.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + xfa/src/fwl/theme/pictureboxtp.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + xfa/src/fwl/theme/pushbuttontp.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + xfa/src/fwl/theme/scrollbartp.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + xfa/src/fwl/theme/widgettp.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dsinclair
PTAL.
4 years, 9 months ago (2016-03-08 16:53:18 UTC) #2
Tom Sepez
LGTM, reviewed the .gyp/.gn changes and spot-checked a few of the .h/.cpp files. https://codereview.chromium.org/1770953004/diff/1/BUILD.gn File ...
4 years, 9 months ago (2016-03-08 17:03:01 UTC) #3
dsinclair
https://codereview.chromium.org/1770953004/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1770953004/diff/1/BUILD.gn#newcode985 BUILD.gn:985: "xfa/src/fwl/lightwidget/app.cpp", On 2016/03/08 17:03:01, Tom Sepez wrote: > just ...
4 years, 9 months ago (2016-03-08 17:15:54 UTC) #4
dsinclair
4 years, 9 months ago (2016-03-08 17:16:05 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6f6388fee1fdb4bec57549fe87a0833b2b20bebe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698