Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 1770943004: Revert of Fix logic handling empty strings in tts. (Closed)

Created:
4 years, 9 months ago by David Tseng
Modified:
4 years, 9 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix logic handling empty strings in tts. (patchset #1 id:1 of https://codereview.chromium.org/1762843002/ ) Reason for revert: It turns out this causes Output.flushNextUtterance to not get applied correctly. Output sometimes sends an empty string as its first utterance. Original issue's description: > Fix logic handling empty strings in tts. > > Previously, we explicitly stopped speech when encountering a call to speak only whitespace. However, since sometimes we get whitespace from an unreliable source, it can actually cause other utterances to be interrupted. > > One such example is Sheets. When arrowing around, we observe some events resulting in empty speech which interrupts cell announcement. > > Committed: https://crrev.com/112cdcfa70a21b026abe0228c9b5ebb2fb287a3e > Cr-Commit-Position: refs/heads/master@{#379308} TBR=dmazzoni@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/d9e1e17f95eda1e857322627b55c269cb48a60e9 Cr-Commit-Position: refs/heads/master@{#380231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/chromevox/host/chrome/tts_background.js View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
David Tseng
Created Revert of Fix logic handling empty strings in tts.
4 years, 9 months ago (2016-03-08 20:13:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770943004/1
4 years, 9 months ago (2016-03-08 20:14:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770943004/1
4 years, 9 months ago (2016-03-08 20:31:35 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/33199)
4 years, 9 months ago (2016-03-08 20:47:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770943004/1
4 years, 9 months ago (2016-03-09 20:59:01 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 21:45:41 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 21:46:50 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9e1e17f95eda1e857322627b55c269cb48a60e9
Cr-Commit-Position: refs/heads/master@{#380231}

Powered by Google App Engine
This is Rietveld 408576698