Chromium Code Reviews
DescriptionRevert of Fix logic handling empty strings in tts. (patchset #1 id:1 of https://codereview.chromium.org/1762843002/ )
Reason for revert:
It turns out this causes Output.flushNextUtterance to not get applied correctly. Output sometimes sends an empty string as its first utterance.
Original issue's description:
> Fix logic handling empty strings in tts.
>
> Previously, we explicitly stopped speech when encountering a call to speak only whitespace. However, since sometimes we get whitespace from an unreliable source, it can actually cause other utterances to be interrupted.
>
> One such example is Sheets. When arrowing around, we observe some events resulting in empty speech which interrupts cell announcement.
>
> Committed: https://crrev.com/112cdcfa70a21b026abe0228c9b5ebb2fb287a3e
> Cr-Commit-Position: refs/heads/master@{#379308}
TBR=dmazzoni@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
Committed: https://crrev.com/d9e1e17f95eda1e857322627b55c269cb48a60e9
Cr-Commit-Position: refs/heads/master@{#380231}
Patch Set 1 #
Messages
Total messages: 10 (3 generated)
|
|||||||||||||||||||