Remove dependency on V2Authenticator from ThirdParty and pairing authenticators.

Remove dependency on V2Authenticator from ThirdParty and pairing authenticators.

Previously third-party and pairing authenticators were responsible for
creation for the underlying SPAKE2 authenticators. Now they get a
callback that they should use instead. This will allow to use them with
Spake2Authenticator.

Also made some minor cleanups in pairiting authenticators, particularly
in the code responsible for fetching the pin after paired auth fails.

BUG=589698
Committed: https://crrev.com/12e320ad7dd026121c0ff50bc7e5cb99a13aa983
Cr-Commit-Position: refs/heads/master@{#379858}

[Sergey Ulanov, 2016-03-07 19:18:13]

Patchset #1 (id:1) has been deleted

[Sergey Ulanov, 2016-03-07 19:22:36]

Description was changed from

==========
Remove dependency on V2Authenticator from ThirdParty and pairing authenticators.

Previusly ThirdParty and Pairing authenticators were responsible for
creation for the underlying SPAKE2 authenticators. Now they get a
callback that they should use instead. This will allow to use them with
Spake2Authenticator.

BUG=589698
==========

to

==========
Remove dependency on V2Authenticator from ThirdParty and pairing authenticators.

Previously third-party and pairing authenticators were responsible for
creation for the underlying SPAKE2 authenticators. Now they get a
callback that they should use instead. This will allow to use them with
Spake2Authenticator.

Also made some minor cleanups in pairiting authenticators, particularly
in the code responsible for fetching the pin after paired auth fails.

BUG=589698
==========

[Sergey Ulanov, 2016-03-07 19:22:36]

sergeyu@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Jamie, 2016-03-07 21:40:19]

lgtm

https://codereview.chromium.org/1770923002/diff/20001/remoting/protocol/authe...
File remoting/protocol/authenticator.h (right):

https://codereview.chromium.org/1770923002/diff/20001/remoting/protocol/authe...
remoting/protocol/authenticator.h:30: // each side of the connection depending
of type of the authprotocol. Client and
s/authprotocol/auth protocol/

https://codereview.chromium.org/1770923002/diff/20001/remoting/protocol/pairi...
File remoting/protocol/pairing_authenticator_base.cc (right):

https://codereview.chromium.org/1770923002/diff/20001/remoting/protocol/pairi...
remoting/protocol/pairing_authenticator_base.cc:31: return
spake2_authenticator_->state();
Either DCHECK that the authenticator is not null, or handle the case where it
is. Probably, this should use the same logic as rejection_reason().

https://codereview.chromium.org/1770923002/diff/20001/remoting/protocol/pairi...
File remoting/protocol/pairing_host_authenticator.cc (right):

https://codereview.chromium.org/1770923002/diff/20001/remoting/protocol/pairi...
remoting/protocol/pairing_host_authenticator.cc:68: return;
This is a change in semantics: if there is no client_id, it no longer calls the
base class ProcessMessage. Is that intentional?

[Sergey Ulanov, 2016-03-07 22:45:06]

https://codereview.chromium.org/1770923002/diff/20001/remoting/protocol/authe...
File remoting/protocol/authenticator.h (right):

https://codereview.chromium.org/1770923002/diff/20001/remoting/protocol/authe...
remoting/protocol/authenticator.h:30: // each side of the connection depending
of type of the authprotocol. Client and
On 2016/03/07 21:40:18, Jamie wrote:
> s/authprotocol/auth protocol/

Done.

https://codereview.chromium.org/1770923002/diff/20001/remoting/protocol/pairi...
File remoting/protocol/pairing_authenticator_base.cc (right):

https://codereview.chromium.org/1770923002/diff/20001/remoting/protocol/pairi...
remoting/protocol/pairing_authenticator_base.cc:31: return
spake2_authenticator_->state();
On 2016/03/07 21:40:18, Jamie wrote:
> Either DCHECK that the authenticator is not null, or handle the case where it
> is. Probably, this should use the same logic as rejection_reason().

Done.

https://codereview.chromium.org/1770923002/diff/20001/remoting/protocol/pairi...
File remoting/protocol/pairing_host_authenticator.cc (right):

https://codereview.chromium.org/1770923002/diff/20001/remoting/protocol/pairi...
remoting/protocol/pairing_host_authenticator.cc:68: return;
On 2016/03/07 21:40:19, Jamie wrote:
> This is a change in semantics: if there is no client_id, it no longer calls
the
> base class ProcessMessage. Is that intentional?

Yes, it's intentional. It doesn't make sense to call
PairingAuthenticatorBase::ProcessMessage() after protocol_error_ is set to true
in line 67. This just makes this error handling code clearer. It doesn't change
behavior because the connection is going to be rejected either way once
protocol_error_ is set to true.

[Sergey Ulanov, 2016-03-07 22:45:24]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-03-07 22:45:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/1770923002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-03-07 22:45:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770923002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770923002/40001

[commit-bot: I haz the power, 2016-03-07 22:49:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 22:49:43]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Sergey Ulanov, 2016-03-08 00:58:07]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2016-03-08 00:58:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770923002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770923002/40001

[commit-bot: I haz the power, 2016-03-08 01:50:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 01:50:44]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Sergey Ulanov, 2016-03-08 17:56:32]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2016-03-08 17:57:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770923002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770923002/40001

[commit-bot: I haz the power, 2016-03-08 18:10:38]

Description was changed from

==========
Remove dependency on V2Authenticator from ThirdParty and pairing authenticators.

Previously third-party and pairing authenticators were responsible for
creation for the underlying SPAKE2 authenticators. Now they get a
callback that they should use instead. This will allow to use them with
Spake2Authenticator.

Also made some minor cleanups in pairiting authenticators, particularly
in the code responsible for fetching the pin after paired auth fails.

BUG=589698
==========

to

==========
Remove dependency on V2Authenticator from ThirdParty and pairing authenticators.

Previously third-party and pairing authenticators were responsible for
creation for the underlying SPAKE2 authenticators. Now they get a
callback that they should use instead. This will allow to use them with
Spake2Authenticator.

Also made some minor cleanups in pairiting authenticators, particularly
in the code responsible for fetching the pin after paired auth fails.

BUG=589698
==========

[commit-bot: I haz the power, 2016-03-08 18:10:39]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-03-08 18:12:52]

Description was changed from

==========
Remove dependency on V2Authenticator from ThirdParty and pairing authenticators.

Previously third-party and pairing authenticators were responsible for
creation for the underlying SPAKE2 authenticators. Now they get a
callback that they should use instead. This will allow to use them with
Spake2Authenticator.

Also made some minor cleanups in pairiting authenticators, particularly
in the code responsible for fetching the pin after paired auth fails.

BUG=589698
==========

to

==========
Remove dependency on V2Authenticator from ThirdParty and pairing authenticators.

Previously third-party and pairing authenticators were responsible for
creation for the underlying SPAKE2 authenticators. Now they get a
callback that they should use instead. This will allow to use them with
Spake2Authenticator.

Also made some minor cleanups in pairiting authenticators, particularly
in the code responsible for fetching the pin after paired auth fails.

BUG=589698

Committed: https://crrev.com/12e320ad7dd026121c0ff50bc7e5cb99a13aa983
Cr-Commit-Position: refs/heads/master@{#379858}
==========

[commit-bot: I haz the power, 2016-03-08 18:12:53]

Patchset 2 (id:??) landed as
https://crrev.com/12e320ad7dd026121c0ff50bc7e5cb99a13aa983
Cr-Commit-Position: refs/heads/master@{#379858}