[wasm] Use the JavaScript WasmModuleBuilder utility in JS tests.

[wasm] Use the JavaScript WasmModuleBuilder utility in JS tests.

R=ahaas@chromium.org,binji@chromium.org
BUG=

Committed: https://crrev.com/c38cd1698b1261be961361215d6013d27f1ac1cf
Cr-Commit-Position: refs/heads/master@{#34559}

[JF, 2016-03-07 18:16:37]

Description was changed from

==========
[wasm] Use the JavaScript WasmModuleBuilder utility in JS tests.

R=ahaas@chromium.org,binji@chromium.org
BUG=
==========

to

==========
[wasm] Use the JavaScript WasmModuleBuilder utility in JS tests.

R=ahaas@chromium.org,binji@chromium.org
BUG=
==========

[ahaas, 2016-03-07 18:36:38]

lgtm

https://codereview.chromium.org/1770913002/diff/1/test/mjsunit/wasm/calls.js
File test/mjsunit/wasm/calls.js (right):

https://codereview.chromium.org/1770913002/diff/1/test/mjsunit/wasm/calls.js#...
test/mjsunit/wasm/calls.js:57: assertModule(module, 65536);
use kMemSize here (or introduce it if it does not exist here yet.)

https://codereview.chromium.org/1770913002/diff/1/test/mjsunit/wasm/calls.js#...
test/mjsunit/wasm/calls.js:71: builder.addMemory(2, 2, true);
Are these "2"s here related to the "2" below in assertModule? If yes, then a
variable for it would be nice.

https://codereview.chromium.org/1770913002/diff/1/test/mjsunit/wasm/calls.js#...
test/mjsunit/wasm/calls.js:87: builder.addMemory(3, 3, true);
Same as above.

https://codereview.chromium.org/1770913002/diff/1/test/mjsunit/wasm/ffi.js
File test/mjsunit/wasm/ffi.js (right):

https://codereview.chromium.org/1770913002/diff/1/test/mjsunit/wasm/ffi.js#ne...
test/mjsunit/wasm/ffi.js:32: var params = [-99, -99, -99, -99];
Why do you initialize exactly 4 parameters here when you use 5 parameters later?

https://codereview.chromium.org/1770913002/diff/1/test/mjsunit/wasm/ffi.js#ne...
test/mjsunit/wasm/ffi.js:51: was_called = false;
I think it would be better to initialize was_called in the beginning of
testCallFFI instead of here.

[titzer, 2016-03-07 19:11:06]

https://codereview.chromium.org/1770913002/diff/1/test/mjsunit/wasm/calls.js
File test/mjsunit/wasm/calls.js (right):

https://codereview.chromium.org/1770913002/diff/1/test/mjsunit/wasm/calls.js#...
test/mjsunit/wasm/calls.js:57: assertModule(module, 65536);
On 2016/03/07 18:36:37, ahaas wrote:
> use kMemSize here (or introduce it if it does not exist here yet.)

Done.

https://codereview.chromium.org/1770913002/diff/1/test/mjsunit/wasm/calls.js#...
test/mjsunit/wasm/calls.js:71: builder.addMemory(2, 2, true);
On 2016/03/07 18:36:38, ahaas wrote:
> Are these "2"s here related to the "2" below in assertModule? If yes, then a
> variable for it would be nice.

Done.

https://codereview.chromium.org/1770913002/diff/1/test/mjsunit/wasm/calls.js#...
test/mjsunit/wasm/calls.js:87: builder.addMemory(3, 3, true);
On 2016/03/07 18:36:37, ahaas wrote:
> Same as above.

Done.

https://codereview.chromium.org/1770913002/diff/1/test/mjsunit/wasm/ffi.js
File test/mjsunit/wasm/ffi.js (right):

https://codereview.chromium.org/1770913002/diff/1/test/mjsunit/wasm/ffi.js#ne...
test/mjsunit/wasm/ffi.js:32: var params = [-99, -99, -99, -99];
On 2016/03/07 18:36:38, ahaas wrote:
> Why do you initialize exactly 4 parameters here when you use 5 parameters
later?

Done.

https://codereview.chromium.org/1770913002/diff/1/test/mjsunit/wasm/ffi.js#ne...
test/mjsunit/wasm/ffi.js:51: was_called = false;
On 2016/03/07 18:36:38, ahaas wrote:
> I think it would be better to initialize was_called in the beginning of
> testCallFFI instead of here.

It gets called multiple types, so, it needs to be reset.

[titzer, 2016-03-07 19:11:11]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-03-07 19:11:12]

The patchset sent to the CQ was uploaded after l-g-t-m from ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/1770913002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-03-07 19:11:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770913002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770913002/20001

[commit-bot: I haz the power, 2016-03-07 19:32:38]

Description was changed from

==========
[wasm] Use the JavaScript WasmModuleBuilder utility in JS tests.

R=ahaas@chromium.org,binji@chromium.org
BUG=
==========

to

==========
[wasm] Use the JavaScript WasmModuleBuilder utility in JS tests.

R=ahaas@chromium.org,binji@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-03-07 19:32:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-07 19:34:37]

Description was changed from

==========
[wasm] Use the JavaScript WasmModuleBuilder utility in JS tests.

R=ahaas@chromium.org,binji@chromium.org
BUG=
==========

to

==========
[wasm] Use the JavaScript WasmModuleBuilder utility in JS tests.

R=ahaas@chromium.org,binji@chromium.org
BUG=

Committed: https://crrev.com/c38cd1698b1261be961361215d6013d27f1ac1cf
Cr-Commit-Position: refs/heads/master@{#34559}
==========

[commit-bot: I haz the power, 2016-03-07 19:34:38]

Patchset 2 (id:??) landed as
https://crrev.com/c38cd1698b1261be961361215d6013d27f1ac1cf
Cr-Commit-Position: refs/heads/master@{#34559}