Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1770903003: Gallery: do not set zoom more than once in a frame. (Closed)

Created:
4 years, 9 months ago by yawano
Modified:
4 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gallery: do not set zoom more than once in a frame. BUG=591033 TEST=manually tested as described in the issue. Committed: https://crrev.com/2afcf7037d39cd4cedf82d235123d5a3efa073c9 Cr-Commit-Position: refs/heads/master@{#379774}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add link to the issue. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M ui/file_manager/gallery/js/slide_mode.js View 1 2 chunks +19 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
yawano
PTAL. Thank you!
4 years, 9 months ago (2016-03-08 06:12:49 UTC) #2
fukino
lgtm with a nit. https://codereview.chromium.org/1770903003/diff/1/ui/file_manager/gallery/js/slide_mode.js File ui/file_manager/gallery/js/slide_mode.js (right): https://codereview.chromium.org/1770903003/diff/1/ui/file_manager/gallery/js/slide_mode.js#newcode2090 ui/file_manager/gallery/js/slide_mode.js:2090: // Request animation frame not ...
4 years, 9 months ago (2016-03-08 06:28:54 UTC) #3
yawano
Thank you! https://codereview.chromium.org/1770903003/diff/1/ui/file_manager/gallery/js/slide_mode.js File ui/file_manager/gallery/js/slide_mode.js (right): https://codereview.chromium.org/1770903003/diff/1/ui/file_manager/gallery/js/slide_mode.js#newcode2090 ui/file_manager/gallery/js/slide_mode.js:2090: // Request animation frame not to set ...
4 years, 9 months ago (2016-03-08 06:41:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770903003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770903003/20001
4 years, 9 months ago (2016-03-08 06:49:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-08 07:29:07 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 07:30:36 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2afcf7037d39cd4cedf82d235123d5a3efa073c9
Cr-Commit-Position: refs/heads/master@{#379774}

Powered by Google App Engine
This is Rietveld 408576698