Revert of Avoid nuking everything when injecting stylesheet.

Revert of Avoid nuking everything when injecting stylesheet. (patchset #1 id:1 of https://codereview.chromium.org/1762443004/ )

Reason for revert:
Seems to have introduced a (slightly flaky) use-after-free on Mac ASan 64:
https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29?numbuilds=100

"All_ParameterizedWebFrameTest.SetForceZeroLayoutHeightWorksAcrossNavigations_1" fails pretty consistently (only 1 success out of ~20 runs), a few others fail only occasionally.

Original issue's description:
> Avoid nuking everything when injecting stylesheet.
>
> Instead do an analyzed update of the Document scope.
>
> Committed: https://crrev.com/6ddb19de461880fa47a5c563f30119e6d05b20be
> Cr-Commit-Position: refs/heads/master@{#379528}

TBR=dstockwell@chromium.org,rune@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/3b2214c75296d5ee376f7a3853af14ab7aafb98d
Cr-Commit-Position: refs/heads/master@{#379580}

[Marc Treib, 2016-03-07 17:43:44]

Created Revert of Avoid nuking everything when injecting stylesheet.

[commit-bot: I haz the power, 2016-03-07 17:44:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770903002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770903002/1

[commit-bot: I haz the power, 2016-03-07 17:46:48]

Description was changed from

==========
Revert of Avoid nuking everything when injecting stylesheet. (patchset #1 id:1
of https://codereview.chromium.org/1762443004/ )

Reason for revert:
Seems to have introduced a (slightly flaky) use-after-free on Mac ASan 64:
https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests...

"All_ParameterizedWebFrameTest.SetForceZeroLayoutHeightWorksAcrossNavigations_1"
fails pretty consistently (only 1 success out of ~20 runs), a few others fail
only occasionally.

Original issue's description:
> Avoid nuking everything when injecting stylesheet.
> 
> Instead do an analyzed update of the Document scope.
> 
> Committed: https://crrev.com/6ddb19de461880fa47a5c563f30119e6d05b20be
> Cr-Commit-Position: refs/heads/master@{#379528}

TBR=dstockwell@chromium.org,rune@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of Avoid nuking everything when injecting stylesheet. (patchset #1 id:1
of https://codereview.chromium.org/1762443004/ )

Reason for revert:
Seems to have introduced a (slightly flaky) use-after-free on Mac ASan 64:
https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests...

"All_ParameterizedWebFrameTest.SetForceZeroLayoutHeightWorksAcrossNavigations_1"
fails pretty consistently (only 1 success out of ~20 runs), a few others fail
only occasionally.

Original issue's description:
> Avoid nuking everything when injecting stylesheet.
> 
> Instead do an analyzed update of the Document scope.
> 
> Committed: https://crrev.com/6ddb19de461880fa47a5c563f30119e6d05b20be
> Cr-Commit-Position: refs/heads/master@{#379528}

TBR=dstockwell@chromium.org,rune@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

[commit-bot: I haz the power, 2016-03-07 17:46:49]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-07 17:48:09]

Description was changed from

==========
Revert of Avoid nuking everything when injecting stylesheet. (patchset #1 id:1
of https://codereview.chromium.org/1762443004/ )

Reason for revert:
Seems to have introduced a (slightly flaky) use-after-free on Mac ASan 64:
https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests...

"All_ParameterizedWebFrameTest.SetForceZeroLayoutHeightWorksAcrossNavigations_1"
fails pretty consistently (only 1 success out of ~20 runs), a few others fail
only occasionally.

Original issue's description:
> Avoid nuking everything when injecting stylesheet.
> 
> Instead do an analyzed update of the Document scope.
> 
> Committed: https://crrev.com/6ddb19de461880fa47a5c563f30119e6d05b20be
> Cr-Commit-Position: refs/heads/master@{#379528}

TBR=dstockwell@chromium.org,rune@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of Avoid nuking everything when injecting stylesheet. (patchset #1 id:1
of https://codereview.chromium.org/1762443004/ )

Reason for revert:
Seems to have introduced a (slightly flaky) use-after-free on Mac ASan 64:
https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests...

"All_ParameterizedWebFrameTest.SetForceZeroLayoutHeightWorksAcrossNavigations_1"
fails pretty consistently (only 1 success out of ~20 runs), a few others fail
only occasionally.

Original issue's description:
> Avoid nuking everything when injecting stylesheet.
>
> Instead do an analyzed update of the Document scope.
>
> Committed: https://crrev.com/6ddb19de461880fa47a5c563f30119e6d05b20be
> Cr-Commit-Position: refs/heads/master@{#379528}

TBR=dstockwell@chromium.org,rune@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/3b2214c75296d5ee376f7a3853af14ab7aafb98d
Cr-Commit-Position: refs/heads/master@{#379580}
==========

[commit-bot: I haz the power, 2016-03-07 17:48:10]

Patchset 1 (id:??) landed as
https://crrev.com/3b2214c75296d5ee376f7a3853af14ab7aafb98d
Cr-Commit-Position: refs/heads/master@{#379580}

[rune, 2016-03-07 19:18:59]

On 2016/03/07 17:48:10, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/3b2214c75296d5ee376f7a3853af14ab7aafb98d
> Cr-Commit-Position: refs/heads/master@{#379580}

Still same problems after the revert.

[Marc Treib, 2016-03-07 19:44:21]

Hm yeah, those tests somehow got super-flaky, but your CL doesn't seem to
be the cause.. I'll reland right now. Sorry for the noise!

On Mon, Mar 7, 2016 at 8:19 PM <rune@opera.com> wrote:

> On 2016/03/07 17:48:10, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/3b2214c75296d5ee376f7a3853af14ab7aafb98d
> > Cr-Commit-Position: refs/heads/master@{#379580}
>
> Still same problems after the revert.
>
> https://codereview.chromium.org/1770903002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Marc Treib, 2016-03-07 19:44:22]

Hm yeah, those tests somehow got super-flaky, but your CL doesn't seem to
be the cause.. I'll reland right now. Sorry for the noise!

On Mon, Mar 7, 2016 at 8:19 PM <rune@opera.com> wrote:

> On 2016/03/07 17:48:10, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/3b2214c75296d5ee376f7a3853af14ab7aafb98d
> > Cr-Commit-Position: refs/heads/master@{#379580}
>
> Still same problems after the revert.
>
> https://codereview.chromium.org/1770903002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Marc Treib, 2016-03-07 19:45:53]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1767163002/ by treib@chromium.org.

The reason for reverting is: Relanding since the original CL doesn't seem to be
the cause of the flakiness..