Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: chrome/browser/search/suggestions/suggestions_source.cc

Issue 1770843002: SuggestionsService: implement SyncServiceObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix2 Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search/suggestions/suggestions_source.cc
diff --git a/chrome/browser/search/suggestions/suggestions_source.cc b/chrome/browser/search/suggestions/suggestions_source.cc
index 1442a5a60faceda0768ca7765c974f07204a7ee0..292c745461d806764e01914c5a5db9b9e9aa12c9 100644
--- a/chrome/browser/search/suggestions/suggestions_source.cc
+++ b/chrome/browser/search/suggestions/suggestions_source.cc
@@ -24,7 +24,6 @@
#include "chrome/browser/search/suggestions/suggestions_service_factory.h"
#include "chrome/common/url_constants.h"
#include "components/suggestions/suggestions_service.h"
-#include "components/suggestions/suggestions_utils.h"
#include "net/base/escape.h"
#include "ui/base/l10n/time_format.h"
#include "ui/gfx/codec/png_codec.h"
@@ -121,18 +120,9 @@ void SuggestionsSource::StartDataRequest(
const content::URLDataSource::GotDataCallback& callback) {
SuggestionsService* suggestions_service =
SuggestionsServiceFactory::GetForProfile(profile_);
-
- if (!suggestions_service) {
- callback.Run(NULL);
- return;
- }
-
- // Since it's a debugging page, it's fine to specify that sync state is
- // initialized.
- suggestions_service->FetchSuggestionsData(
- INITIALIZED_ENABLED_HISTORY,
- base::Bind(&SuggestionsSource::OnSuggestionsAvailable,
- weak_ptr_factory_.GetWeakPtr(), callback));
+ OnSuggestionsAvailable(callback,
+ suggestions_service->GetSuggestionsDataFromCache());
+ suggestions_service->FetchSuggestionsData();
}
std::string SuggestionsSource::GetMimeType(const std::string& path) const {

Powered by Google App Engine
This is Rietveld 408576698