Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Side by Side Diff: src/ic/ic.cc

Issue 1770833002: Speed up indexed interceptor handling in the LookupIterator (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/lookup.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/ic/ic.h" 5 #include "src/ic/ic.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api.h" 8 #include "src/api.h"
9 #include "src/arguments.h" 9 #include "src/arguments.h"
10 #include "src/base/bits.h" 10 #include "src/base/bits.h"
(...skipping 2853 matching lines...) Expand 10 before | Expand all | Expand 10 after
2864 } 2864 }
2865 2865
2866 2866
2867 RUNTIME_FUNCTION(Runtime_LoadElementWithInterceptor) { 2867 RUNTIME_FUNCTION(Runtime_LoadElementWithInterceptor) {
2868 // TODO(verwaest): This should probably get the holder and receiver as input. 2868 // TODO(verwaest): This should probably get the holder and receiver as input.
2869 HandleScope scope(isolate); 2869 HandleScope scope(isolate);
2870 Handle<JSObject> receiver = args.at<JSObject>(0); 2870 Handle<JSObject> receiver = args.at<JSObject>(0);
2871 DCHECK(args.smi_at(1) >= 0); 2871 DCHECK(args.smi_at(1) >= 0);
2872 uint32_t index = args.smi_at(1); 2872 uint32_t index = args.smi_at(1);
2873 Handle<Object> result; 2873 Handle<Object> result;
2874 ASSIGN_RETURN_FAILURE_ON_EXCEPTION( 2874 LookupIterator it(isolate, receiver, index, receiver);
2875 isolate, result, Object::GetElement(isolate, receiver, index)); 2875 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, result, Object::GetProperty(&it));
2876 return *result; 2876 return *result;
2877 } 2877 }
2878 2878
2879 2879
2880 RUNTIME_FUNCTION(Runtime_LoadIC_MissFromStubFailure) { 2880 RUNTIME_FUNCTION(Runtime_LoadIC_MissFromStubFailure) {
2881 TimerEventScope<TimerEventIcMiss> timer(isolate); 2881 TimerEventScope<TimerEventIcMiss> timer(isolate);
2882 TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8"), "V8.IcMiss"); 2882 TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8"), "V8.IcMiss");
2883 HandleScope scope(isolate); 2883 HandleScope scope(isolate);
2884 Handle<Object> receiver = args.at<Object>(0); 2884 Handle<Object> receiver = args.at<Object>(0);
2885 Handle<Name> key = args.at<Name>(1); 2885 Handle<Name> key = args.at<Name>(1);
(...skipping 17 matching lines...) Expand all
2903 KeyedLoadICNexus nexus(vector, vector_slot); 2903 KeyedLoadICNexus nexus(vector, vector_slot);
2904 KeyedLoadIC ic(IC::EXTRA_CALL_FRAME, isolate, &nexus); 2904 KeyedLoadIC ic(IC::EXTRA_CALL_FRAME, isolate, &nexus);
2905 ic.UpdateState(receiver, key); 2905 ic.UpdateState(receiver, key);
2906 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, result, ic.Load(receiver, key)); 2906 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, result, ic.Load(receiver, key));
2907 } 2907 }
2908 2908
2909 return *result; 2909 return *result;
2910 } 2910 }
2911 } // namespace internal 2911 } // namespace internal
2912 } // namespace v8 2912 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/lookup.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698