Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: tests/compiler/dart2js/analyze_api_test.dart

Issue 1770813002: Update the whitelisted warnings in dart2js/analyze_api_test. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/compiler/dart2js/analyze_test_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/analyze_api_test.dart
diff --git a/tests/compiler/dart2js/analyze_api_test.dart b/tests/compiler/dart2js/analyze_api_test.dart
index d4f2f9f833608d9378226dad010f2d5c0d8a8cc5..377c915c4004800f971a10ee0036a5212b8ede78 100644
--- a/tests/compiler/dart2js/analyze_api_test.dart
+++ b/tests/compiler/dart2js/analyze_api_test.dart
@@ -6,8 +6,8 @@ library analyze_api;
import 'package:sdk_library_metadata/libraries.dart';
import 'analyze_helper.dart';
-import "package:async_helper/async_helper.dart";
-
+import 'package:async_helper/async_helper.dart';
+import 'package:compiler/src/diagnostics/messages.dart' show MessageKind;
/**
* Map of white-listed warnings and errors.
*
@@ -17,9 +17,20 @@ import "package:async_helper/async_helper.dart";
* Use an identifiable suffix of the file uri as key. Use a fixed substring of
* the error/warning message in the list of white-listings for each file.
*/
-// TODO(johnniwinther): Support canonical URIs as keys and message kinds as
-// values.
+// TODO(johnniwinther): Support canonical URIs as keys.
const Map<String, List<String>> WHITE_LIST = const {
+ "html_dart2js.dart": const [
+ // These suppressions are tracked by issue 25928.
+ "'KeyEvent' doesn't implement the getter 'sourceDevice'",
+ "'KeyEvent' doesn't implement the getter 'code'",
+ "'KeyEvent' doesn't implement the getter 'key'",
+ "No member named '_pageX' in class 'UIEvent'.",
+ "No member named '_pageY' in class 'UIEvent'.",
+ "No member named '_layerX' in class 'UIEvent'.",
+ "No member named '_layerY' in class 'UIEvent'.",
+ "No member named 'clipboardData' in class 'KeyboardEvent'.",
+ "No member named 'clipboardData' in class 'Event'."
+ ]
};
void main() {
« no previous file with comments | « no previous file | tests/compiler/dart2js/analyze_test_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698