Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1770813002: Update the whitelisted warnings in dart2js/analyze_api_test. (Closed)

Created:
4 years, 9 months ago by Bill Hesse
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update the whitelisted warnings in dart2js/analyze_api_test. Modifies cl https://codereview.chromium.org/1773583002/edit BUG=https://github.com/dart-lang/sdk/issues/25928 R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/b8eeb2f4387cc954358553a290fe92ec913b77a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M tests/compiler/dart2js/analyze_api_test.dart View 2 chunks +15 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/analyze_test_test.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
4 years, 9 months ago (2016-03-07 12:04:06 UTC) #2
Johnni Winther
lgtm
4 years, 9 months ago (2016-03-07 12:06:24 UTC) #3
Bill Hesse
4 years, 9 months ago (2016-03-07 12:26:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b8eeb2f4387cc954358553a290fe92ec913b77a9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698