Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1770793002: Move EnsureFastWritableElements into the elements accessor. (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move EnsureFastWritableElements into the elements accessor. Additionally clean up the elements accessor api a bit. BUG= Committed: https://crrev.com/cf43d2a788276bfb25618c30653ba3900b53a9fd Cr-Commit-Position: refs/heads/master@{#34549}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -156 lines) Patch
M src/builtins.cc View 1 2 3 4 5 6 7 11 chunks +31 lines, -83 lines 0 comments Download
M src/elements.h View 2 chunks +3 lines, -14 lines 0 comments Download
M src/elements.cc View 1 2 3 4 5 6 7 8 9 10 11 chunks +46 lines, -59 lines 0 comments Download

Messages

Total messages: 25 (13 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-07 10:26:52 UTC) #2
Camillo Bruni
lgtm
4 years, 9 months ago (2016-03-07 11:47:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770793002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770793002/140001
4 years, 9 months ago (2016-03-07 12:04:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770793002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770793002/160001
4 years, 9 months ago (2016-03-07 12:09:43 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/2447) v8_linux_dbg_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 9 months ago (2016-03-07 12:58:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770793002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770793002/180001
4 years, 9 months ago (2016-03-07 13:34:37 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/2454) v8_linux_dbg_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 9 months ago (2016-03-07 14:04:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770793002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770793002/200001
4 years, 9 months ago (2016-03-07 15:18:18 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/13338)
4 years, 9 months ago (2016-03-07 15:28:54 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770793002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770793002/200001
4 years, 9 months ago (2016-03-07 16:14:44 UTC) #22
commit-bot: I haz the power
Committed patchset #11 (id:200001)
4 years, 9 months ago (2016-03-07 16:25:05 UTC) #23
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 16:26:33 UTC) #25
Message was sent while issue was closed.
Patchset 11 (id:??) landed as
https://crrev.com/cf43d2a788276bfb25618c30653ba3900b53a9fd
Cr-Commit-Position: refs/heads/master@{#34549}

Powered by Google App Engine
This is Rietveld 408576698