Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1770783003: Revert of [debugger] break at each initialization in a multiple var declaration. (Closed)

Created:
4 years, 9 months ago by Michael Achenbach
Modified:
4 years, 9 months ago
Reviewers:
rossberg, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [debugger] break at each initialization in a multiple var declaration. (patchset #1 id:1 of https://codereview.chromium.org/1768973002/ ) Reason for revert: [Sheriff] Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/5160 Original issue's description: > [debugger] break at each initialization in a multiple var declaration. > > R=rossberg@chromium.org > BUG=v8:4807 > LOG=N > > Committed: https://crrev.com/ee98147ea0d994bcfb0d14d43f490ee828d2426f > Cr-Commit-Position: refs/heads/master@{#34531} TBR=rossberg@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4807 Committed: https://crrev.com/c6dbb071a3f42cd132057f6c131f0c88b7e81055 Cr-Commit-Position: refs/heads/master@{#34538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -105 lines) Patch
M src/parsing/pattern-rewriter.cc View 4 chunks +16 lines, -11 lines 0 comments Download
M test/cctest/test-debug.cc View 8 chunks +9 lines, -8 lines 0 comments Download
D test/mjsunit/debug-multiple-var-decl.js View 1 chunk +0 lines, -74 lines 0 comments Download
M test/mjsunit/debug-stepin-accessor-ic.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-stepin-string-template.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/es6/debug-stepnext-for.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/harmony/debug-stepin-default-parameters.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/debug-stepin-proxies.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/regress/regress-debug-deopt-while-recompile.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [debugger] break at each initialization in a multiple var declaration.
4 years, 9 months ago (2016-03-07 12:53:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770783003/1
4 years, 9 months ago (2016-03-07 12:53:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 12:53:32 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 12:54:01 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6dbb071a3f42cd132057f6c131f0c88b7e81055
Cr-Commit-Position: refs/heads/master@{#34538}

Powered by Google App Engine
This is Rietveld 408576698