Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1770773002: [interpreter, debugger] add some missing statement positions. (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter, debugger] add some missing statement positions. R=rmcilroy@chromium.org, vogelheim@chromium.org BUG=v8:4690 LOG=N Committed: https://crrev.com/4a7722c9930a42ba0e8feeece286d74834211a7e Cr-Commit-Position: refs/heads/master@{#34569} Committed: https://crrev.com/5586ff666e69697416ffefcdf64081598b0b9c71 Cr-Commit-Position: refs/heads/master@{#34573}

Patch Set 1 #

Patch Set 2 : update expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M src/full-codegen/full-codegen.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/bytecode-generator.cc View 11 chunks +14 lines, -0 lines 0 comments Download
M test/cctest/cctest.status View 1 1 chunk +4 lines, -9 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 34 (16 generated)
Yang
4 years, 9 months ago (2016-03-07 09:57:50 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770773002/1
4 years, 9 months ago (2016-03-07 09:58:07 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/16553)
4 years, 9 months ago (2016-03-07 10:24:34 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770773002/1
4 years, 9 months ago (2016-03-07 10:39:47 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-07 10:58:43 UTC) #11
vogelheim
lgtm
4 years, 9 months ago (2016-03-07 11:38:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770773002/1
4 years, 9 months ago (2016-03-07 11:39:41 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/11939)
4 years, 9 months ago (2016-03-07 11:46:12 UTC) #16
Yang
Michael, could you take a brief look at this? Thanks.
4 years, 9 months ago (2016-03-08 05:59:08 UTC) #18
rmcilroy
Lgtm
4 years, 9 months ago (2016-03-08 07:24:13 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770773002/1
4 years, 9 months ago (2016-03-08 07:49:48 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 07:51:49 UTC) #22
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4a7722c9930a42ba0e8feeece286d74834211a7e Cr-Commit-Position: refs/heads/master@{#34569}
4 years, 9 months ago (2016-03-08 07:53:13 UTC) #24
Yang
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1772293002/ by yangguo@chromium.org. ...
4 years, 9 months ago (2016-03-08 08:28:51 UTC) #25
Yang
On 2016/03/08 08:28:51, Yang wrote: > A revert of this CL (patchset #1 id:1) has ...
4 years, 9 months ago (2016-03-08 08:45:00 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770773002/20001
4 years, 9 months ago (2016-03-08 08:45:36 UTC) #30
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-08 09:07:52 UTC) #32
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 09:09:24 UTC) #34
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5586ff666e69697416ffefcdf64081598b0b9c71
Cr-Commit-Position: refs/heads/master@{#34573}

Powered by Google App Engine
This is Rietveld 408576698