|
|
Description[interpreter, debugger] add some missing statement positions.
R=rmcilroy@chromium.org, vogelheim@chromium.org
BUG=v8:4690
LOG=N
Committed: https://crrev.com/4a7722c9930a42ba0e8feeece286d74834211a7e
Cr-Commit-Position: refs/heads/master@{#34569}
Committed: https://crrev.com/5586ff666e69697416ffefcdf64081598b0b9c71
Cr-Commit-Position: refs/heads/master@{#34573}
Patch Set 1 #Patch Set 2 : update expectations #
Messages
Total messages: 34 (16 generated)
The CQ bit was checked by yangguo@chromium.org
The CQ bit was unchecked by yangguo@chromium.org
The CQ bit was checked by yangguo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770773002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/16553)
The CQ bit was checked by yangguo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770773002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by yangguo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770773002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/11939)
yangguo@chromium.org changed reviewers: + mstarzinger@chromium.org
Michael, could you take a brief look at this? Thanks.
Lgtm
The CQ bit was checked by yangguo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770773002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [interpreter, debugger] add some missing statement positions. R=rmcilroy@chromium.org, vogelheim@chromium.org BUG=v8:4690 LOG=N ========== to ========== [interpreter, debugger] add some missing statement positions. R=rmcilroy@chromium.org, vogelheim@chromium.org BUG=v8:4690 LOG=N Committed: https://crrev.com/4a7722c9930a42ba0e8feeece286d74834211a7e Cr-Commit-Position: refs/heads/master@{#34569} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4a7722c9930a42ba0e8feeece286d74834211a7e Cr-Commit-Position: refs/heads/master@{#34569}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1772293002/ by yangguo@chromium.org. The reason for reverting is: failing tests with ignition..
Message was sent while issue was closed.
Description was changed from ========== [interpreter, debugger] add some missing statement positions. R=rmcilroy@chromium.org, vogelheim@chromium.org BUG=v8:4690 LOG=N Committed: https://crrev.com/4a7722c9930a42ba0e8feeece286d74834211a7e Cr-Commit-Position: refs/heads/master@{#34569} ========== to ========== [interpreter, debugger] add some missing statement positions. R=rmcilroy@chromium.org, vogelheim@chromium.org BUG=v8:4690 LOG=N Committed: https://crrev.com/4a7722c9930a42ba0e8feeece286d74834211a7e Cr-Commit-Position: refs/heads/master@{#34569} ==========
On 2016/03/08 08:28:51, Yang wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/1772293002/ by mailto:yangguo@chromium.org. > > The reason for reverting is: failing tests with ignition.. Turns out the expectation changes clashed with another debugger CL. Ignition now no longer fixes some of the tests.
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rmcilroy@chromium.org, vogelheim@chromium.org Link to the patchset: https://codereview.chromium.org/1770773002/#ps20001 (title: "update expectations")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770773002/20001
Message was sent while issue was closed.
Description was changed from ========== [interpreter, debugger] add some missing statement positions. R=rmcilroy@chromium.org, vogelheim@chromium.org BUG=v8:4690 LOG=N Committed: https://crrev.com/4a7722c9930a42ba0e8feeece286d74834211a7e Cr-Commit-Position: refs/heads/master@{#34569} ========== to ========== [interpreter, debugger] add some missing statement positions. R=rmcilroy@chromium.org, vogelheim@chromium.org BUG=v8:4690 LOG=N Committed: https://crrev.com/4a7722c9930a42ba0e8feeece286d74834211a7e Cr-Commit-Position: refs/heads/master@{#34569} ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [interpreter, debugger] add some missing statement positions. R=rmcilroy@chromium.org, vogelheim@chromium.org BUG=v8:4690 LOG=N Committed: https://crrev.com/4a7722c9930a42ba0e8feeece286d74834211a7e Cr-Commit-Position: refs/heads/master@{#34569} ========== to ========== [interpreter, debugger] add some missing statement positions. R=rmcilroy@chromium.org, vogelheim@chromium.org BUG=v8:4690 LOG=N Committed: https://crrev.com/4a7722c9930a42ba0e8feeece286d74834211a7e Cr-Commit-Position: refs/heads/master@{#34569} Committed: https://crrev.com/5586ff666e69697416ffefcdf64081598b0b9c71 Cr-Commit-Position: refs/heads/master@{#34573} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/5586ff666e69697416ffefcdf64081598b0b9c71 Cr-Commit-Position: refs/heads/master@{#34573} |