content/shell/browser/layout_test/layout_test_push_messaging_service.h - Issue 1770763003: Revert of Partial implementation of subscription restrictions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_push_messaging_service.h

Issue 1770763003: Revert of Partial implementation of subscription restrictions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/push_messaging/push_messaging_dispatcher.cc ('k') | content/shell/browser/layout_test/layout_test_push_messaging_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/layout_test_push_messaging_service.h

diff --git a/content/shell/browser/layout_test/layout_test_push_messaging_service.h b/content/shell/browser/layout_test/layout_test_push_messaging_service.h

index 5e5a7a481cb4ff43c9a1243f8d8de7b6a8d8a1e7..eb5e7e4e0c8443a8ed4aed1836c18e3583aa180f 100644

--- a/content/shell/browser/layout_test/layout_test_push_messaging_service.h

+++ b/content/shell/browser/layout_test/layout_test_push_messaging_service.h

@@ -17,8 +17,6 @@

namespace content {

-struct PushSubscriptionOptions;

class LayoutTestPushMessagingService : public PushMessagingService {

public:

LayoutTestPushMessagingService();

@@ -29,14 +27,16 @@

void SubscribeFromDocument(

const GURL& requesting_origin,

int64_t service_worker_registration_id,

+ const std::string& sender_id,

int renderer_id,

int render_frame_id,

- const PushSubscriptionOptions& options,

+ bool user_visible,

const PushMessagingService::RegisterCallback& callback) override;

void SubscribeFromWorker(