| Index: chrome/browser/push_messaging/push_messaging_browsertest.cc
|
| diff --git a/chrome/browser/push_messaging/push_messaging_browsertest.cc b/chrome/browser/push_messaging/push_messaging_browsertest.cc
|
| index bcad2bc84f12ec87234f0a3c1670dcb5e3531ed6..03fb92945e31173a188a84bad8409d49d2c785a0 100644
|
| --- a/chrome/browser/push_messaging/push_messaging_browsertest.cc
|
| +++ b/chrome/browser/push_messaging/push_messaging_browsertest.cc
|
| @@ -44,7 +44,6 @@
|
| #include "components/gcm_driver/common/gcm_messages.h"
|
| #include "components/gcm_driver/gcm_client.h"
|
| #include "content/public/browser/web_contents.h"
|
| -#include "content/public/common/content_switches.h"
|
| #include "content/public/test/browser_test_utils.h"
|
| #include "content/public/test/test_utils.h"
|
| #include "net/test/embedded_test_server/embedded_test_server.h"
|
| @@ -100,13 +99,6 @@
|
| InProcessBrowserTest::SetUp();
|
| }
|
|
|
| - void SetUpCommandLine(base::CommandLine* command_line) override {
|
| - // Enable experiemntal features for subscription restrictions.
|
| - command_line->AppendSwitch(
|
| - switches::kEnableExperimentalWebPlatformFeatures);
|
| - InProcessBrowserTest::SetUpCommandLine(command_line);
|
| - }
|
| -
|
| // InProcessBrowserTest:
|
| void SetUpOnMainThread() override {
|
| gcm_service_ = static_cast<gcm::FakeGCMProfileService*>(
|
| @@ -172,8 +164,7 @@
|
| void RequestAndDenyPermission();
|
|
|
| void TryToSubscribeSuccessfully(
|
| - const std::string& expected_push_subscription_info,
|
| - bool use_key = true);
|
| + const std::string& expected_push_subscription_id);
|
|
|
| std::string GetEndpointForSubscriptionId(const std::string& subscription_id) {
|
| return std::string(kPushMessagingEndpoint) + "/" + subscription_id;
|
| @@ -255,8 +246,7 @@
|
| }
|
|
|
| void PushMessagingBrowserTest::TryToSubscribeSuccessfully(
|
| - const std::string& expected_push_subscription_info,
|
| - bool use_key) {
|
| + const std::string& expected_push_subscription_id) {
|
| std::string script_result;
|
|
|
| EXPECT_TRUE(RunScript("registerServiceWorker()", &script_result));
|
| @@ -264,14 +254,8 @@
|
|
|
| RequestAndAcceptPermission();
|
|
|
| - if (use_key) {
|
| - EXPECT_TRUE(RunScript("subscribePush()", &script_result));
|
| - } else {
|
| - // Test backwards compatibility with old ID based subscriptions.
|
| - EXPECT_TRUE(RunScript("subscribePushWithoutKey()", &script_result));
|
| - }
|
| -
|
| - EXPECT_EQ(GetEndpointForSubscriptionId(expected_push_subscription_info),
|
| + EXPECT_TRUE(RunScript("subscribePush()", &script_result));
|
| + EXPECT_EQ(GetEndpointForSubscriptionId(expected_push_subscription_id),
|
| script_result);
|
| }
|
|
|
| @@ -296,8 +280,8 @@
|
| }
|
|
|
| IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest,
|
| - SubscribeWithoutKeySuccessNotificationsGranted) {
|
| - TryToSubscribeSuccessfully("1-0" /* expected_push_subscription_id */, false);
|
| + SubscribeSuccessNotificationsGranted) {
|
| + TryToSubscribeSuccessfully("1-0" /* expected_push_subscription_id */);
|
|
|
| PushMessagingAppIdentifier app_identifier =
|
| GetAppIdentifierForServiceWorkerRegistration(0LL);
|
| @@ -306,46 +290,21 @@
|
| }
|
|
|
| IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest,
|
| - SubscribeSuccessNotificationsGranted) {
|
| - TryToSubscribeSuccessfully("1-0" /* expected_push_subscription_id */);
|
| + SubscribeSuccessNotificationsPrompt) {
|
| + std::string script_result;
|
| +
|
| + ASSERT_TRUE(RunScript("registerServiceWorker()", &script_result));
|
| + ASSERT_EQ("ok - service worker registered", script_result);
|
| +
|
| + GetPermissionBubbleManager()->set_auto_response_for_test(
|
| + PermissionBubbleManager::ACCEPT_ALL);
|
| + ASSERT_TRUE(RunScript("subscribePush()", &script_result));
|
| + EXPECT_EQ(GetEndpointForSubscriptionId("1-0"), script_result);
|
|
|
| PushMessagingAppIdentifier app_identifier =
|
| GetAppIdentifierForServiceWorkerRegistration(0LL);
|
| EXPECT_EQ(app_identifier.app_id(), gcm_service()->last_registered_app_id());
|
| EXPECT_EQ("1234567890", gcm_service()->last_registered_sender_ids()[0]);
|
| -}
|
| -
|
| -IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest,
|
| - SubscribeSuccessNotificationsPrompt) {
|
| - std::string script_result;
|
| -
|
| - ASSERT_TRUE(RunScript("registerServiceWorker()", &script_result));
|
| - ASSERT_EQ("ok - service worker registered", script_result);
|
| -
|
| - GetPermissionBubbleManager()->set_auto_response_for_test(
|
| - PermissionBubbleManager::ACCEPT_ALL);
|
| - ASSERT_TRUE(RunScript("subscribePush()", &script_result));
|
| - EXPECT_EQ(GetEndpointForSubscriptionId("1-0"), script_result);
|
| -
|
| - PushMessagingAppIdentifier app_identifier =
|
| - GetAppIdentifierForServiceWorkerRegistration(0LL);
|
| - EXPECT_EQ(app_identifier.app_id(), gcm_service()->last_registered_app_id());
|
| - EXPECT_EQ("1234567890", gcm_service()->last_registered_sender_ids()[0]);
|
| -}
|
| -
|
| -IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, SubscribeFailureBadKey) {
|
| - std::string script_result;
|
| -
|
| - ASSERT_TRUE(RunScript("registerServiceWorker()", &script_result));
|
| - ASSERT_EQ("ok - service worker registered", script_result);
|
| -
|
| - RequestAndAcceptPermission();
|
| -
|
| - ASSERT_TRUE(RunScript("subscribePushBadKey()", &script_result));
|
| - EXPECT_EQ(
|
| - "InvalidAccessError - Failed to execute 'subscribe' on 'PushManager': "
|
| - "The provided applicationServerKey is not valid.",
|
| - script_result);
|
| }
|
|
|
| IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest,
|
|
|