Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 177073022: Use chromium's gyp if third_party is not available. (Closed)

Created:
6 years, 9 months ago by scroggo
Modified:
6 years, 9 months ago
Reviewers:
epoger, djsollen
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Use chromium's gyp if third_party is not available. This is for building Android.mk inside an Android tree where there is no third_party directory. Committed: http://code.google.com/p/skia/source/detail?r=13614

Patch Set 1 #

Patch Set 2 : Update a comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M platform_tools/android/bin/android_framework_gyp.py View 1 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
scroggo
As with https://codereview.chromium.org/178223015/, alternatively, I could have the bot run the script before removing third_party. ...
6 years, 9 months ago (2014-02-26 22:44:09 UTC) #1
djsollen
I'm completely fine with a change like this since it is used in a tool ...
6 years, 9 months ago (2014-02-27 13:53:03 UTC) #2
scroggo
6 years, 9 months ago (2014-02-27 14:09:41 UTC) #3
scroggo
On 2014/02/26 22:44:09, scroggo wrote: > As with https://codereview.chromium.org/178223015/, alternatively, I could have > the ...
6 years, 9 months ago (2014-02-27 15:10:37 UTC) #4
epoger
Python code LGTM I'll defer to your guys' call as to whether the change is ...
6 years, 9 months ago (2014-02-27 18:33:44 UTC) #5
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 9 months ago (2014-02-27 18:40:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/177073022/20001
6 years, 9 months ago (2014-02-27 18:40:38 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-02-27 18:58:53 UTC) #8
Message was sent while issue was closed.
Change committed as 13614

Powered by Google App Engine
This is Rietveld 408576698