Issue 177073006: add isClipEmpty() -- encourage clients to call this rather than checking clipFoo() results

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 177073006: add isClipEmpty() -- encourage clients to call this rather than checking clipFoo() results (Closed)

Created:
6 years, 10 months ago by reed1

Modified:
6 years, 10 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

add isClipEmpty() -- encourage clients to call this rather than checking clipFoo() results BUG=skia: R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=13568

Patch Set 2 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	include/core/SkCanvas.h	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
	M	src/core/SkCanvas.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + 1 nit https://codereview.chromium.org/177073006/diff/1/include/core/SkCanvas.h File include/core/SkCanvas.h (right): https://codereview.chromium.org/177073006/diff/1/include/core/SkCanvas.h#newcode979 include/core/SkCanvas.h:979: * result, subsequent calls will ...

6 years, 10 months ago (2014-02-24 19:33:13 UTC) #2

reed1

https://codereview.chromium.org/177073006/diff/1/include/core/SkCanvas.h File include/core/SkCanvas.h (right): https://codereview.chromium.org/177073006/diff/1/include/core/SkCanvas.h#newcode979 include/core/SkCanvas.h:979: * result, subsequent calls will be cheap (until the ...

6 years, 10 months ago (2014-02-24 19:36:18 UTC) #3

reed1

6 years, 10 months ago (2014-02-24 19:38:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r13568 (presubmit successful).

Expand Messages | Collapse Messages

Issue 177073006: add isClipEmpty() -- encourage clients to call this rather than checking clipFoo() results (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages