Chromium Code Reviews| Index: Source/core/workers/AbstractWorker.h | 
| diff --git a/Source/core/workers/AbstractWorker.h b/Source/core/workers/AbstractWorker.h | 
| index 213d7c980ae15ca020cc73d9ef42ceeac329f0d4..1710a8b4b3668b1581ec97ce3fb2082579bf30a0 100644 | 
| --- a/Source/core/workers/AbstractWorker.h | 
| +++ b/Source/core/workers/AbstractWorker.h | 
| @@ -36,6 +36,7 @@ | 
| #include "core/events/EventListener.h" | 
| #include "core/events/EventTarget.h" | 
| #include "core/events/ThreadLocalEventNames.h" | 
| +#include "heap/Handle.h" | 
| #include "wtf/PassRefPtr.h" | 
| #include "wtf/RefCounted.h" | 
| #include "wtf/RefPtr.h" | 
| @@ -47,8 +48,9 @@ class ExceptionState; | 
| class KURL; | 
| class ExecutionContext; | 
| -class AbstractWorker : public RefCounted<AbstractWorker>, public EventTargetWithInlineData, public ActiveDOMObject { | 
| - REFCOUNTED_EVENT_TARGET(AbstractWorker); | 
| +class AbstractWorker : public RefCountedWillBeRefCountedGarbageCollected<AbstractWorker>, public EventTargetWithInlineData, public ActiveDOMObject { | 
| + DECLARE_GC_INFO; | 
| + DEFINE_EVENT_TARGET_REFCOUNTING(RefCountedWillBeRefCountedGarbageCollected<AbstractWorker>); | 
| public: | 
| // EventTarget APIs | 
| virtual ExecutionContext* executionContext() const OVERRIDE FINAL { return ActiveDOMObject::executionContext(); } | 
| @@ -58,6 +60,8 @@ public: | 
| AbstractWorker(ExecutionContext*); | 
| virtual ~AbstractWorker(); | 
| + void trace(Visitor*) { } | 
| 
 
Mads Ager (chromium)
2014/02/24 13:27:53
Please make this one virtual and implement it in a
 
haraken
2014/02/24 13:28:36
This should be: virtual void trace(Visitor*) = 0.
 
 | 
| + | 
| protected: | 
| // Helper function that converts a URL to an absolute URL and checks the result for validity. | 
| KURL resolveURL(const String& url, ExceptionState&); |