Source/bindings/tests/results/V8TestObject.cpp - Issue 177073004: Oilpan: move core/workers to oilpan's heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestObject.cpp

Issue 177073004: Oilpan: move core/workers to oilpan's heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/tests/results/V8TestObject.cpp

diff --git a/Source/bindings/tests/results/V8TestObject.cpp b/Source/bindings/tests/results/V8TestObject.cpp

index be7ed3726f57f6a4e6aa4ae6b346ec50c4abe56d..7d2554ac2797d6fbdd93268a49d8cc6311029c29 100644

--- a/Source/bindings/tests/results/V8TestObject.cpp

+++ b/Source/bindings/tests/results/V8TestObject.cpp

@@ -2233,7 +2233,7 @@ static void messagePortArrayAttributeGetterCallback(v8::Local<v8::String>, const

static void messagePortArrayAttributeSetter(v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)

{

TestObject* imp = V8TestObject::toNative(info.Holder());

- V8TRYCATCH_VOID(Vector<RefPtr<MessagePort> >, cppValue, (toRefPtrNativeArray<MessagePort, V8MessagePort>(jsValue, 0, info.GetIsolate())));

+ V8TRYCATCH_VOID(Vector<RefPtrWillBeRawPtr<MessagePort> >, cppValue, (toRefPtrNativeArray<MessagePort, V8MessagePort>(jsValue, 0, info.GetIsolate())));

haraken 2014/02/24 13:28:36 Why do we observe a change to bindings/tests/resul

imp->setMessagePortArray(cppValue);

}

« no previous file with comments | « no previous file | Source/bindings/v8/WorkerScriptController.cpp » ('j') | Source/bindings/v8/WorkerScriptController.cpp » ('J')