Fix remaining tests that use border-image.

Fix remaining tests that use border-image.

With this, all known tests should work with UAs that are
compliant with border-image spec.

BUG=559258
Committed: https://crrev.com/125a2daee2eeef179f2059bc7b99d4373e211542
Cr-Commit-Position: refs/heads/master@{#379608}

[cavalcantii1, 2016-03-06 19:07:24]

cavalcantii@chromium.org changed reviewers:
+ alancutter@chromium.org, rbyers@chromium.org

[alancutter (OOO until 2018), 2016-03-07 00:11:02]

lgtm. I would prefer to see the next expectations checked in with this patch if
there are no platform specific expectations. You can pass --reset-results to
run-webkit-tests to rebaseline locally.

https://codereview.chromium.org/1770713002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/borders/border-image-border-radius.html
(right):

https://codereview.chromium.org/1770713002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/borders/border-image-border-radius.html:1: 
No need to add newline.

[cavalcantii1, 2016-03-07 18:46:08]

Alan

Thanks for the review, I will comment inline.

> lgtm. I would prefer to see the next expectations checked in with this patch
if
> there are no platform specific expectations. You can pass --reset-results to
> run-webkit-tests to rebaseline locally.
> 

Coolio, I will check that next time.

>
https://codereview.chromium.org/1770713002/diff/20001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/fast/borders/border-image-border-radius.html:1:

> No need to add newline.

Fixed.

[cavalcantii1, 2016-03-07 18:46:38]

The CQ bit was checked by cavalcantii@chromium.org

[cavalcantii1, 2016-03-07 18:46:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/1770713002/#ps40001
(title: "Remove unneeded new line in a test.")

[commit-bot: I haz the power, 2016-03-07 18:47:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770713002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770713002/40001

[commit-bot: I haz the power, 2016-03-07 19:29:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-07 19:30:22]

Description was changed from

==========
Fix remaining tests that use border-image.

With this, all known tests should work with UAs that are
compliant with border-image spec.

BUG=559258
==========

to

==========
Fix remaining tests that use border-image.

With this, all known tests should work with UAs that are
compliant with border-image spec.

BUG=559258

Committed: https://crrev.com/125a2daee2eeef179f2059bc7b99d4373e211542
Cr-Commit-Position: refs/heads/master@{#379608}
==========

[commit-bot: I haz the power, 2016-03-07 19:30:23]

Patchset 3 (id:??) landed as
https://crrev.com/125a2daee2eeef179f2059bc7b99d4373e211542
Cr-Commit-Position: refs/heads/master@{#379608}

[ortuno, 2016-03-08 00:47:18]

On 2016/03/07 at 19:30:23, commit-bot wrote:
> Patchset 3 (id:??) landed as
https://crrev.com/125a2daee2eeef179f2059bc7b99d4373e211542
> Cr-Commit-Position: refs/heads/master@{#379608}

svg/as-border-image/svg-as-border-image.html
svg/as-border-image/svg-as-border-image-2.html

are now failing:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28...

[cavalcantii1, 2016-03-08 01:04:58]

I will have a look on it.

On Mon, Mar 7, 2016 at 4:47 PM, <ortuno@chromium.org> wrote:

> On 2016/03/07 at 19:30:23, commit-bot wrote:
> > Patchset 3 (id:??) landed as
> https://crrev.com/125a2daee2eeef179f2059bc7b99d4373e211542
> > Cr-Commit-Position: refs/heads/master@{#379608}
>
> svg/as-border-image/svg-as-border-image.html
> svg/as-border-image/svg-as-border-image-2.html
>
> are now failing:
>
>
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28...
>
> https://codereview.chromium.org/1770713002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[cavalcantii1, 2016-03-08 01:04:59]

I will have a look on it.

On Mon, Mar 7, 2016 at 4:47 PM, <ortuno@chromium.org> wrote:

> On 2016/03/07 at 19:30:23, commit-bot wrote:
> > Patchset 3 (id:??) landed as
> https://crrev.com/125a2daee2eeef179f2059bc7b99d4373e211542
> > Cr-Commit-Position: refs/heads/master@{#379608}
>
> svg/as-border-image/svg-as-border-image.html
> svg/as-border-image/svg-as-border-image-2.html
>
> are now failing:
>
>
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28...
>
> https://codereview.chromium.org/1770713002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[cavalcantii1, 2016-03-08 03:33:40]

I finished a fresh build of content shell (Mac retina@OSX 10.11.3).

The tests will fail with a text diff, see output:
https://gist.github.com/Adenilson/56cc81bde1853aa5d2d7

And the detailed diff for first test (the second is pretty much the same case):
https://gist.github.com/Adenilson/d199817218885bb540ca

Even though the last change on the expectations for mac retina in my computer
shows a revision (7fdb98cd72204a342026a7213cbaa19bf87ab88b) that has a reference
to the new baselines, inspecting the contents of the expectation file reveals
that it was not updated (or has wrong content i.e. still has the warning message
and border: none).

I'm assuming that if this case happens only in retina, I can just generate new
baselines locally and upload them to a new issue?

[cavalcantii1, 2016-03-08 03:36:57]

This issue has the updated expectations for retina:
https://codereview.chromium.org/1774693003