Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1770703002: Use error-names for 'specializationOf'. (Closed)

Created:
4 years, 9 months ago by floitsch
Modified:
4 years, 9 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, Brian Wilkerson
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use error-names for 'specializationOf'. The sub-ids are harder to read and maintain. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/c7de97729c7b6d65bce6a862eb60e2872733b302

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -17 lines) Patch
M pkg/dart_messages/lib/shared_messages.dart View 10 chunks +26 lines, -17 lines 0 comments Download
M pkg/dart_messages/test/dart_messages_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
floitsch
4 years, 9 months ago (2016-03-07 09:32:28 UTC) #2
Johnni Winther
lgtm
4 years, 9 months ago (2016-03-07 10:04:09 UTC) #3
floitsch
4 years, 9 months ago (2016-03-07 10:37:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c7de97729c7b6d65bce6a862eb60e2872733b302 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698