Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 17707002: Implement Custom Elements inserted and removed callbacks. (Closed)

Created:
7 years, 6 months ago by dominicc (has gone to gerrit)
Modified:
7 years, 5 months ago
CC:
blink-reviews, Nils Barth (inactive), jsbell+bindings_chromium.org, webcomponents-bugzilla_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, do-not-use
Visibility:
Public.

Description

Implement Custom Elements inserted and removed callbacks. This also fixes the order in which the ready callback is dispatched as a result of parsing. BUG=247166

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+439 lines, -96 lines) Patch
A LayoutTests/fast/dom/custom/callbacks-parsing.html View 1 chunk +30 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/custom/callbacks-parsing-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/custom/callbacks-upgrade.html View 1 chunk +43 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/custom/callbacks-upgrade-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/custom/inserted-callback.html View 1 chunk +39 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/custom/inserted-callback-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/custom/lifecycle-ready-innerHTML.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/custom/lifecycle-ready-innerHTML-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/custom/lifecycle-ready-paste.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/lifecycle-ready-paste-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/ready-callback.html View 1 chunk +28 lines, -24 lines 0 comments Download
M LayoutTests/fast/dom/custom/ready-callback-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A LayoutTests/fast/dom/custom/removed-callback.html View 1 chunk +34 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/custom/removed-callback-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/custom/transfer-callbacks.html View 1 chunk +51 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/custom/transfer-callbacks-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/bindings/v8/CustomElementConstructorBuilder.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/v8/CustomElementConstructorBuilder.cpp View 2 chunks +14 lines, -7 lines 1 comment Download
M Source/bindings/v8/V8CustomElementCallback.h View 1 chunk +7 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8CustomElementCallback.cpp View 4 chunks +32 lines, -7 lines 0 comments Download
M Source/bindings/v8/V8HiddenPropertyName.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/CustomElementCallback.h View 1 chunk +12 lines, -4 lines 1 comment Download
M Source/core/dom/CustomElementCallbackDispatcher.h View 3 chunks +15 lines, -11 lines 1 comment Download
M Source/core/dom/CustomElementCallbackDispatcher.cpp View 3 chunks +55 lines, -12 lines 0 comments Download
M Source/core/dom/CustomElementRegistry.h View 2 chunks +7 lines, -4 lines 1 comment Download
M Source/core/dom/CustomElementRegistry.cpp View 5 chunks +25 lines, -7 lines 1 comment Download
M Source/core/dom/Document.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Element.cpp View 3 chunks +16 lines, -5 lines 0 comments Download
M Source/core/scripts/make_names.pl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
dominicc (has gone to gerrit)
This depends on Issue 17639010 going first.
7 years, 6 months ago (2013-06-25 17:03:19 UTC) #1
dglazkov
LGTM. The tests are great! Did you write them with W3C conformance test suite in ...
7 years, 6 months ago (2013-06-25 18:04:31 UTC) #2
abarth-chromium
7 years, 6 months ago (2013-06-25 21:13:56 UTC) #3
https://codereview.chromium.org/17707002/diff/1/Source/bindings/v8/CustomElem...
File Source/bindings/v8/CustomElementConstructorBuilder.cpp (right):

https://codereview.chromium.org/17707002/diff/1/Source/bindings/v8/CustomElem...
Source/bindings/v8/CustomElementConstructorBuilder.cpp:156:
v8::Handle<v8::Value> value = m_prototype->Get(v8String(name, isolate));
Would you be willing to add a test that hooks each of these calls in JavaScript
with __defineGetter__ and blows away the document?  I want to make sure to see
ClusterFuzz with those tests cases.  (Maybe you've already done that.)

Powered by Google App Engine
This is Rietveld 408576698